You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/09/11 23:57:37 UTC

[GitHub] codecov-io edited a comment on issue #5862: fix sqllab logging

codecov-io edited a comment on issue #5862: fix sqllab logging
URL: https://github.com/apache/incubator-superset/pull/5862#issuecomment-420465538
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5862?src=pr&el=h1) Report
   > Merging [#5862](https://codecov.io/gh/apache/incubator-superset/pull/5862?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01212c3755ba0368ed04e3126268571165639469?src=pr&el=desc) will **increase** coverage by `0.04%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5862/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5862?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #5862      +/-   ##
   ==========================================
   + Coverage   63.69%   63.73%   +0.04%     
   ==========================================
     Files         374      374              
     Lines       23325    23325              
     Branches     2607     2607              
   ==========================================
   + Hits        14857    14867      +10     
   + Misses       8455     8445      -10     
     Partials       13       13
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5862?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/5862/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `71.42% <100%> (ø)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5862/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `81.13% <0%> (+0.75%)` | :arrow_up: |
   | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5862/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `55.19% <0%> (+0.87%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5862?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5862?src=pr&el=footer). Last update [01212c3...9ead09f](https://codecov.io/gh/apache/incubator-superset/pull/5862?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org