You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/03/13 06:45:18 UTC
[GitHub] [helix] narendly opened a new pull request #895: Update
listClusters() in ZkHelixAdmin
narendly opened a new pull request #895: Update listClusters() in ZkHelixAdmin
URL: https://github.com/apache/helix/pull/895
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Resolves #891
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
This PR updates getClusters() in ZkHelixAdmin in realm-aware mode. It is difficult to reason about getting all clusters - and this method, on single-realm mode, is also broken anyways because in the case users create nested clusters, this method will end up returning nothing. This update is backward-compatible for single-realm users.
Ideally, users should use Metadata Store Directory Service to get the list of all clusters.
### Tests
See https://github.com/apache/helix/pull/892
### Commits
- [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation (Optional)
- [ ] In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Code Quality
- [x] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on a change in pull request #895: Update
listClusters() in ZkHelixAdmin
Posted by GitBox <gi...@apache.org>.
pkuwm commented on a change in pull request #895: Update listClusters() in ZkHelixAdmin
URL: https://github.com/apache/helix/pull/895#discussion_r392504297
##########
File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
##########
@@ -1925,7 +1931,10 @@ private void validate() {
// Resolve RealmAwareZkClientConfig
if (realmAwareZkClientConfig == null) {
- realmAwareZkClientConfig = new RealmAwareZkClient.RealmAwareZkClientConfig();
+ // ZkHelixAdmin should have ZNRecordSerializer set by default
+ realmAwareZkClientConfig = new RealmAwareZkClient.RealmAwareZkClientConfig()
+ .setZkSerializer(
+ new org.apache.helix.zookeeper.datamodel.serializer.ZNRecordSerializer());
Review comment:
Nit, I think currently we can still use the deprecated ZNRecordSerializer. Once the deprecated one is removed, we will also refactor and change it here. If we put the long path here, maybe we would not find it when removing the deprecated one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on issue #895: Update listClusters() in
ZkHelixAdmin
Posted by GitBox <gi...@apache.org>.
narendly commented on issue #895: Update listClusters() in ZkHelixAdmin
URL: https://github.com/apache/helix/pull/895#issuecomment-598982274
This PR is ready to be merged, approved by @pkuwm
This PR updates getClusters() in ZkHelixAdmin in realm-aware mode. It is difficult to reason about getting all clusters - and this method, on single-realm mode, is also broken anyways because in the case users create nested clusters, this method will end up returning nothing. This update is backward-compatible for single-realm users.
Ideally, users should use Metadata Store Directory Service to get the list of all clusters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly merged pull request #895: Update listClusters() in
ZkHelixAdmin
Posted by GitBox <gi...@apache.org>.
narendly merged pull request #895: Update listClusters() in ZkHelixAdmin
URL: https://github.com/apache/helix/pull/895
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on a change in pull request #895: Update
listClusters() in ZkHelixAdmin
Posted by GitBox <gi...@apache.org>.
narendly commented on a change in pull request #895: Update listClusters() in ZkHelixAdmin
URL: https://github.com/apache/helix/pull/895#discussion_r392536170
##########
File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
##########
@@ -1925,7 +1931,10 @@ private void validate() {
// Resolve RealmAwareZkClientConfig
if (realmAwareZkClientConfig == null) {
- realmAwareZkClientConfig = new RealmAwareZkClient.RealmAwareZkClientConfig();
+ // ZkHelixAdmin should have ZNRecordSerializer set by default
+ realmAwareZkClientConfig = new RealmAwareZkClient.RealmAwareZkClientConfig()
+ .setZkSerializer(
+ new org.apache.helix.zookeeper.datamodel.serializer.ZNRecordSerializer());
Review comment:
But then we'd be using a deprecated component. I don't think using the package prefix is wrong per se..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org