You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org> on 2014/09/18 09:32:33 UTC
[jira] [Resolved] (SOLR-6115) Cleanup enum/string action types in
Overseer, OverseerCollectionProcessor and CollectionHandler
[ https://issues.apache.org/jira/browse/SOLR-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar resolved SOLR-6115.
-----------------------------------------
Resolution: Fixed
Fix Version/s: (was: 4.9)
4.11
Assignee: Shalin Shekhar Mangar
Thanks Erick for the original suggestion of fixing this mess :)
> Cleanup enum/string action types in Overseer, OverseerCollectionProcessor and CollectionHandler
> -----------------------------------------------------------------------------------------------
>
> Key: SOLR-6115
> URL: https://issues.apache.org/jira/browse/SOLR-6115
> Project: Solr
> Issue Type: Task
> Components: SolrCloud
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 4.11, 5.0
>
> Attachments: SOLR-6115-branch_4x.patch, SOLR-6115.patch
>
>
> The enum/string handling for actions in Overseer and OCP is a mess. We should fix it.
> From: https://issues.apache.org/jira/browse/SOLR-5466?focusedCommentId=13918059&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13918059
> {quote}
> I started to untangle the fact that we have all the strings in OverseerCollectionProcessor, but also have a nice CollectionAction enum. And the commands are intermingled with parameters, it all seems rather confusing. Does it make sense to use the enum rather than the strings? Or somehow associate the two? Probably something for another JIRA though...
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org