You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by garrensmith <gi...@git.apache.org> on 2015/11/11 13:22:03 UTC
[GitHub] couchdb-nmo pull request: [WIP] support npm3
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-nmo/pull/12
[WIP] support npm3
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/garrensmith/couchdb-nmo modules-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-nmo/pull/12.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12
----
commit 9135618547c4db4d59fbebd68f0220a6c1cc56f0
Author: Garren Smith <ga...@gmail.com>
Date: 2015-11-11T12:19:28Z
support npm3
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: [WIP] support npm3
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-nmo/pull/12#issuecomment-156051271
After discussion with @janl and @kxepal we don't need this anymore. I'm closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: [WIP] support npm3
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-nmo/pull/12#issuecomment-155766479
its because we bundle all the dependencies. So when someone installs nmo they have everything. Don't need to fetch anything and we shouldn't have any dependency version issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: [WIP] support npm3
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-nmo/pull/12#issuecomment-155766286
> Files changed: 7,615
O.O
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: [WIP] support npm3
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-nmo/pull/12#issuecomment-155767624
It's all nice from technical side, but from legal one are all the deps compatible with Apache v2 license and doesn't including them all violates any ASF rule? I'm in doubts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: [WIP] support npm3
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-nmo/pull/12#issuecomment-155769402
Yes. Thats why its [WIP] we have to decide how to manage this. Any suggestions would be great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: [WIP] support npm3
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-nmo/pull/12
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---