You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/12/15 18:08:34 UTC
[GitHub] [netbeans] hlavki opened a new pull request #2597: [NETBEANS-5070] fix errors on text selection
hlavki opened a new pull request #2597:
URL: https://github.com/apache/netbeans/pull/2597
I think the best solution would be to rewrite a lot of `ide/lib.terminalemulator` code. Anyway this PR fixes text selection problem which was brought by #2509.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #2597: [NETBEANS-5070] fix errors on text selection
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2597:
URL: https://github.com/apache/netbeans/pull/2597
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2597: [NETBEANS-5070] fix errors on text selection
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2597:
URL: https://github.com/apache/netbeans/pull/2597#issuecomment-752678163
I just reopened the issue, there is still a problem on windows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2597: [NETBEANS-5070] fix errors on text selection
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2597:
URL: https://github.com/apache/netbeans/pull/2597#issuecomment-748565349
Tested. Works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2597: [NETBEANS-5070] fix errors on text selection
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2597:
URL: https://github.com/apache/netbeans/pull/2597#issuecomment-747689687
Thank you - handling is much better with this on "normal res" (scale 1x). I see a slight problem in selection - it seems there is an of-by-one problem:
As you can see the dot in "dummy.bpmn" is not select, but it is part of the exported data:
```
workspace Öffentlich sketchbook 'System Volume Information' Tracks 'VirtualBox VMs'
Bilder dokumentationen dummy.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2597: [NETBEANS-5070] fix errors on text selection
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2597:
URL: https://github.com/apache/netbeans/pull/2597#issuecomment-748565392
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2597: [NETBEANS-5070] fix errors on text selection
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2597:
URL: https://github.com/apache/netbeans/pull/2597#issuecomment-748498764
Works for me and looks sane. I tested this and it seems to work correctly (including selection) on windows and linux again at scale 1x.
@lkishalmi could you also please have a look?
@hlavki does this still fix the problems on highres?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists