[GitHub] cordova-android pull request: Fix for shouldInterceptRequest metho...

[attaurrehman <gi...@git.apache.org>]

GitHub user attaurrehman opened a pull request:

    https://github.com/apache/cordova-android/pull/106

    Fix for shouldInterceptRequest method in IceCreamCordovaWebViewClient

    From: http://callback.markmail.org/thread/45xdpomxjbmgwtpe
    
    Probably a good idea. If you want to send a pull-request, or at least file an issue, we can take a look at this.
    
    On Tue, Jul 15, 2014 at 3:08 AM, atta ur rehman <at...@gmail.com> wrote:
    
    Hi folks,
    
    Thank you very much for Cordova!
    
    Is this the right place to ask why the line number 69 in the class https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/IceCreamCordovaWebViewClient.java returns null instead of return super.shouldInterceptRequest(view, url);
    
    For the sake of argument, let's assume that I'm on Android 4.x and later, and I have changed the class hierarchy in Cordova source where CordovaWebViewClient extends from my XWebViewClient instead of stock android framework WebViewClient.
    
    In this case, I think ICCWVC should bubble the calls of shouldInterceptRequest that it doesn't want to handle to give super classes a change to handle them.
    
    Any comments, please.
    
    Thanks.
    
    ATTA 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/attaurrehman/cordova-android ice_cream_cordova_webview_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #106
    
----
commit 2b3fb6e69adcdc8669143c2164fdd302c7f2d70f
Author: atta ur rehman <at...@worldpay.com>
Date:   2014-07-15T14:28:20Z

    shouldInterceptRequest method in should pass the control to the super class if it doesn't need to special-case the given URL. The allows super class(s) to handle given URL the way they prefer.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-android pull request: Fix for shouldInterceptRequest metho...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-android/pull/106


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---