You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/14 07:47:59 UTC
[GitHub] [rocketmq-client-go] BLAZZ opened a new pull request, #972: Replacing github.com/satori/go.uuid with github.com/google/uuid
BLAZZ opened a new pull request, #972:
URL: https://github.com/apache/rocketmq-client-go/pull/972
Library github.com/satori/go.uuid didn't release new version in 4 years and there is CVE-2021-3538 vulnerability.
and github.com/satori/go.uuid v1.2.1, is conflict with v1.2.0 when we use dubbo-go who use v1.2.1, so we cant use both in a project.
fix #919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] xujianhai666 commented on pull request #972: Replacing github.com/satori/go.uuid with github.com/google/uuid
Posted by "xujianhai666 (via GitHub)" <gi...@apache.org>.
xujianhai666 commented on PR #972:
URL: https://github.com/apache/rocketmq-client-go/pull/972#issuecomment-1486360896
cc @ShannonDing @wenfengwang @duhenglucky @vongosling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] Folyd commented on pull request #972: Replacing github.com/satori/go.uuid with github.com/google/uuid
Posted by "Folyd (via GitHub)" <gi...@apache.org>.
Folyd commented on PR #972:
URL: https://github.com/apache/rocketmq-client-go/pull/972#issuecomment-1486280382
Can we merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-commenter commented on pull request #972: Replacing github.com/satori/go.uuid with github.com/google/uuid
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #972:
URL: https://github.com/apache/rocketmq-client-go/pull/972#issuecomment-1350955654
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/972?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#972](https://codecov.io/gh/apache/rocketmq-client-go/pull/972?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (12740f0) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/f56a2dba2af8ab0b88869e589b0820f49b728f8c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f56a2db) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #972 +/- ##
=======================================
Coverage 23.33% 23.33%
=======================================
Files 52 52
Lines 7265 7265
=======================================
Hits 1695 1695
Misses 5338 5338
Partials 232 232
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `28.07% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] fuyou001 commented on pull request #972: Replacing github.com/satori/go.uuid with github.com/google/uuid
Posted by "fuyou001 (via GitHub)" <gi...@apache.org>.
fuyou001 commented on PR #972:
URL: https://github.com/apache/rocketmq-client-go/pull/972#issuecomment-1486367778
> Can we merge this?
it will be merge soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] fuyou001 merged pull request #972: Replacing github.com/satori/go.uuid with github.com/google/uuid
Posted by "fuyou001 (via GitHub)" <gi...@apache.org>.
fuyou001 merged PR #972:
URL: https://github.com/apache/rocketmq-client-go/pull/972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org