You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Cong Wang <cw...@twopensource.com> on 2015/03/04 21:16:47 UTC
Review Request 31501: (5/6) Add flowid to IP classifier
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31501/
-----------------------------------------------------------
Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
Bugs: MESOS-2422
https://issues.apache.org/jira/browse/MESOS-2422
Repository: mesos
Description
-------
We need to read this flowid in the following patch.
Diffs
-----
src/linux/routing/filter/ip.hpp e43cadf
src/linux/routing/filter/ip.cpp f24be9b
Diff: https://reviews.apache.org/r/31501/diff/
Testing
-------
Tested together with the whole patchset.
Thanks,
Cong Wang
Re: Review Request 31501: (5/6) Add flowid to IP classifier
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31501/#review75264
-----------------------------------------------------------
This line can probably be killed. Option has a default constructor to set it to NONE.
flowId_(None())
- Chi Zhang
On March 4, 2015, 8:16 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31501/
> -----------------------------------------------------------
>
> (Updated March 4, 2015, 8:16 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
>
>
> Bugs: MESOS-2422
> https://issues.apache.org/jira/browse/MESOS-2422
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We need to read this flowid in the following patch.
>
>
> Diffs
> -----
>
> src/linux/routing/filter/ip.hpp e43cadf
> src/linux/routing/filter/ip.cpp f24be9b
>
> Diff: https://reviews.apache.org/r/31501/diff/
>
>
> Testing
> -------
>
> Tested together with the whole patchset.
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 31501: (4/5) Add flowid to IP classifier
Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31501/
-----------------------------------------------------------
(Updated March 9, 2015, 9:51 p.m.)
Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
Bugs: MESOS-2422
https://issues.apache.org/jira/browse/MESOS-2422
Repository: mesos
Description
-------
We need to read this flowid in the following patch.
Diffs (updated)
-----
src/linux/routing/filter/ip.hpp 0d1dd5013e27f82550962be11eac103a8b87023e
src/linux/routing/filter/ip.cpp 9d8639b744e6f54cabaa9c866c02fec83dbcdbfa
Diff: https://reviews.apache.org/r/31501/diff/
Testing
-------
Tested together with the whole patchset.
Thanks,
Cong Wang
Re: Review Request 31501: (4/5) Add flowid to IP classifier
Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31501/
-----------------------------------------------------------
(Updated March 9, 2015, 6:34 p.m.)
Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
Changes
-------
Address review comments
Summary (updated)
-----------------
(4/5) Add flowid to IP classifier
Bugs: MESOS-2422
https://issues.apache.org/jira/browse/MESOS-2422
Repository: mesos
Description
-------
We need to read this flowid in the following patch.
Diffs (updated)
-----
src/linux/routing/filter/ip.hpp a9afeb8
src/linux/routing/filter/ip.cpp f04c0dc
Diff: https://reviews.apache.org/r/31501/diff/
Testing
-------
Tested together with the whole patchset.
Thanks,
Cong Wang
Re: Review Request 31501: (5/6) Add flowid to IP classifier
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31501/#review75718
-----------------------------------------------------------
Still cannot view the diff.
- Jie Yu
On March 4, 2015, 8:16 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31501/
> -----------------------------------------------------------
>
> (Updated March 4, 2015, 8:16 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
>
>
> Bugs: MESOS-2422
> https://issues.apache.org/jira/browse/MESOS-2422
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We need to read this flowid in the following patch.
>
>
> Diffs
> -----
>
> src/linux/routing/filter/ip.hpp e43cadf
> src/linux/routing/filter/ip.cpp f24be9b
>
> Diff: https://reviews.apache.org/r/31501/diff/
>
>
> Testing
> -------
>
> Tested together with the whole patchset.
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 31501: (5/6) Add flowid to IP classifier
Posted by Cong Wang <cw...@twopensource.com>.
> On March 4, 2015, 10:13 p.m., Chi Zhang wrote:
> > no diffs :)
Try to download it, and blame rb. :)
- Cong
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31501/#review75251
-----------------------------------------------------------
On March 4, 2015, 8:16 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31501/
> -----------------------------------------------------------
>
> (Updated March 4, 2015, 8:16 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
>
>
> Bugs: MESOS-2422
> https://issues.apache.org/jira/browse/MESOS-2422
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We need to read this flowid in the following patch.
>
>
> Diffs
> -----
>
> src/linux/routing/filter/ip.hpp e43cadf
> src/linux/routing/filter/ip.cpp f24be9b
>
> Diff: https://reviews.apache.org/r/31501/diff/
>
>
> Testing
> -------
>
> Tested together with the whole patchset.
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 31501: (5/6) Add flowid to IP classifier
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31501/#review75251
-----------------------------------------------------------
no diffs :)
- Chi Zhang
On March 4, 2015, 8:16 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31501/
> -----------------------------------------------------------
>
> (Updated March 4, 2015, 8:16 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
>
>
> Bugs: MESOS-2422
> https://issues.apache.org/jira/browse/MESOS-2422
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We need to read this flowid in the following patch.
>
>
> Diffs
> -----
>
> src/linux/routing/filter/ip.hpp e43cadf
> src/linux/routing/filter/ip.cpp f24be9b
>
> Diff: https://reviews.apache.org/r/31501/diff/
>
>
> Testing
> -------
>
> Tested together with the whole patchset.
>
>
> Thanks,
>
> Cong Wang
>
>