You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by CodeLife2012 <gi...@git.apache.org> on 2017/04/09 06:09:49 UTC
[GitHub] incubator-weex pull request #235: [ios]Explicit start samples by terminal.
GitHub user CodeLife2012 opened a pull request:
https://github.com/apache/incubator-weex/pull/235
[ios]Explicit start samples by terminal.
Open use the default system application to open the file, maybe user has changed to a different application, then start sample will fail.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/CodeLife2012/incubator-weex ExplicitOpen
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/235.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #235
----
commit 636a72581ff6199be800b737b306886a80cec4a9
Author: Karl Peng <co...@gmail.com>
Date: 2017-04-09T05:57:12Z
[ios]Explicit start samples by terminal.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #235: [ios]Explicit start samples by terminal.
Posted by CodeLife2012 <gi...@git.apache.org>.
Github user CodeLife2012 commented on the issue:
https://github.com/apache/incubator-weex/pull/235
Don't known why `Copy Pods Resources ` is deleted, I just change the last line of `Start Samples`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #235: [ios]Explicit start samples by terminal.
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/235
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true" data-kind="Error">
4 Errors
</th>
</tr>
</thead>
<tbody>
<tr>
<td>:no_entry_sign:</td>
<td data-sticky="false"><strong><a href="https://github.com/CodeLife2012/incubator-weex/blob/636a72581ff6199be800b737b306886a80cec4a9/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L50">ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L50</a></strong>: incompatible pointer types sending \u2018NSNumber *\u2019 to parameter of type \u2018NSIndexPath * _Nullable\u2019 [-Werror,-Wincompatible-pointer-types] <br /><code>
[_headerToIndexTable setObject:@(idx) forKey:controller.headerComponent];
</code></td>
</tr>
<tr>
<td>:no_entry_sign:</td>
<td data-sticky="false"><strong><a href="https://github.com/CodeLife2012/incubator-weex/blob/636a72581ff6199be800b737b306886a80cec4a9/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L50">ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L50</a></strong>: incompatible pointer types sending \u2018WXHeaderComponent *\u2019 to parameter of type \u2018WXCellComponent * _Nullable\u2019 [-Werror,-Wincompatible-pointer-types] <br /><code>
[_headerToIndexTable setObject:@(idx) forKey:controller.headerComponent];
</code></td>
</tr>
<tr>
<td>:no_entry_sign:</td>
<td data-sticky="false"><strong><a href="https://github.com/CodeLife2012/incubator-weex/blob/636a72581ff6199be800b737b306886a80cec4a9/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L114">ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L114</a></strong>: incompatible pointer types sending \u2018WXHeaderComponent *\u2019 to parameter of type \u2018WXCellComponent * _Nullable\u2019 [-Werror,-Wincompatible-pointer-types] <br /><code>
NSNumber *index = [_headerToIndexTable objectForKey:header];
</code></td>
</tr>
<tr>
<td>:no_entry_sign:</td>
<td data-sticky="false"><strong><a href="https://github.com/CodeLife2012/incubator-weex/blob/636a72581ff6199be800b737b306886a80cec4a9/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L114">ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L114</a></strong>: incompatible pointer types initializing \u2018NSNumber *\u2019 with an expression of type \u2018NSIndexPath * _Nullable\u2019 [-Werror,-Wincompatible-pointer-types] <br /><code>
NSNumber *index = [_headerToIndexTable objectForKey:header];
</code></td>
</tr>
</tbody>
</table>
<p align="right" data-meta="generated_by_danger">
Generated by :no_entry_sign: <a href="http://danger.systems/">danger</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #235: [ios]Explicit start samples by terminal.
Posted by cxfeng1 <gi...@git.apache.org>.
Github user cxfeng1 commented on the issue:
https://github.com/apache/incubator-weex/pull/235
Seems good to me, @acton393 Please have a code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #235: [ios]Explicit start samples by terminal.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/235
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #235: [ios]Explicit start samples by terminal.
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on the issue:
https://github.com/apache/incubator-weex/pull/235
@CodeLife2012 cool, thx for your contribution, that's good ~~~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---