(magpie) branch main updated: fix(skill-evals): align code-review footer fixtures with the contributing-guide link (#1503)

[po...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/magpie.git


The following commit(s) were added to refs/heads/main by this push:
     new 2d53e230 fix(skill-evals): align code-review footer fixtures with the contributing-guide link (#1503)
2d53e230 is described below

commit 2d53e23086e7979f75a77a9cf7baf757a62690d9
Author: Jarek Potiuk <ja...@potiuk.com>
AuthorDate: Sun Oct 4 03:31:32 2026 +0200

    fix(skill-evals): align code-review footer fixtures with the contributing-guide link (#1503)
    
    #1407 replaced the Airflow-specific `contributing-docs/05_pull_requests.rst`
    link in the code-review footer with `[Contributing guide](<upstream_contributing_docs_url>)`,
    but the step-7b attribution eval still told the grader the footer ends with
    the Airflow pull-requests doc, and its "footer present" fixtures carried the
    old link text. Describe the link by its config key and use the current link
    text in the fixtures. The suite passes 4/4.
    
    Generated-by: Claude Opus 5
---
 .../fixtures/case-1-footer-present/report.md                        | 2 +-
 .../fixtures/case-4-footer-role-neutral-comment/report.md           | 2 +-
 .../step-7b-review-body-attribution/fixtures/system-prompt.md       | 6 ++++--
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/tools/skill-evals/evals/pr-management-code-review/step-7b-review-body-attribution/fixtures/case-1-footer-present/report.md b/tools/skill-evals/evals/pr-management-code-review/step-7b-review-body-attribution/fixtures/case-1-footer-present/report.md
index 0c909762..1b2f2555 100644
--- a/tools/skill-evals/evals/pr-management-code-review/step-7b-review-body-attribution/fixtures/case-1-footer-present/report.md
+++ b/tools/skill-evals/evals/pr-management-code-review/step-7b-review-body-attribution/fixtures/case-1-footer-present/report.md
@@ -16,4 +16,4 @@
 > in.*
 >
 > *More on how Airflow handles maintainer review:*
-> [contributing-docs/05_pull_requests.rst](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst).
+> [Contributing guide](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst).
diff --git a/tools/skill-evals/evals/pr-management-code-review/step-7b-review-body-attribution/fixtures/case-4-footer-role-neutral-comment/report.md b/tools/skill-evals/evals/pr-management-code-review/step-7b-review-body-attribution/fixtures/case-4-footer-role-neutral-comment/report.md
index d3515309..a89a3116 100644
--- a/tools/skill-evals/evals/pr-management-code-review/step-7b-review-body-attribution/fixtures/case-4-footer-role-neutral-comment/report.md
+++ b/tools/skill-evals/evals/pr-management-code-review/step-7b-review-body-attribution/fixtures/case-4-footer-role-neutral-comment/report.md
@@ -15,4 +15,4 @@
 > finding is mis-applied, please reply on the PR.*
 >
 > *More on how Airflow handles maintainer review:*
-> [contributing-docs/05_pull_requests.rst](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst).
+> [Contributing guide](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst).
diff --git a/tools/skill-evals/evals/pr-management-code-review/step-7b-review-body-attribution/fixtures/system-prompt.md b/tools/skill-evals/evals/pr-management-code-review/step-7b-review-body-attribution/fixtures/system-prompt.md
index dc1374e7..0ce4132f 100644
--- a/tools/skill-evals/evals/pr-management-code-review/step-7b-review-body-attribution/fixtures/system-prompt.md
+++ b/tools/skill-evals/evals/pr-management-code-review/step-7b-review-body-attribution/fixtures/system-prompt.md
@@ -19,8 +19,10 @@ A `COMMENT` body may use either sentence, since GitHub lets a `COMMENT`
 post without confirmed maintainer access: which one is correct depends
 on whether the poster's collaborator permission was confirmed, not on
 the words themselves; either sentence, taken verbatim, satisfies the
-rule. The footer ends with a link to the project's contributing
-pull-requests doc (`contributing-docs/05_pull_requests.rst`). The
+rule. The footer ends with a `[Contributing guide](...)` link to the
+project's contributing docs (`upstream_contributing_docs_url` from
+`project.md`; a project that has not set it drops those last two
+lines). The
 footer must be present verbatim: a paraphrase, a partial version, a
 blend of the two sentences, or a missing footer all fail the rule.