[GitHub] [hive] pvary commented on a change in pull request #2701: [DRAFT - DO NOT MERGE] Delete statements draft for Iceberg tables

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2701:
URL: https://github.com/apache/hive/pull/2701#discussion_r724382379



##########
File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
##########
@@ -120,16 +124,23 @@ public void commitTask(TaskAttemptContext originalContext) throws IOException {
             if (table != null) {
               HiveIcebergRecordWriter writer = writers.get(output);
               DataFile[] closedFiles;
+              List<DeleteFile> deleteFiles = Collections.emptyList();
               if (writer != null) {
                 closedFiles = writer.dataFiles();
+                deleteFiles = writer.getDeleteFiles();

Review comment:
       nit: writer.deleteFiles()




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org