[GitHub] [netbeans] mbien commented on pull request #3836: Fix console encoding on JDK 18 (Maven + general execution)

[GitBox <gi...@apache.org>]

mbien commented on pull request #3836:
URL: https://github.com/apache/netbeans/pull/3836#issuecomment-1075618316


   @matthiasblaesing I like the change, good job.
   
   My main concern was that there might be something we overlook, since NB is a big codebase. We should ask windows users to test on JDK 18 once there is a RC to get more coverage.
   
   Do you think we could simulate the JDK 18 behavior on JDK 11 by setting `native.encoding` to system native and `file.encoding` to UTF-8 and run a CI job on windows?
   
   One cosmetic nitpick would be that this is duplicated code, but unless more places show up where we need it its probably ok to leave it like this. Potentially add a comment to inform that the code needs to be updated in two places if there are any changes.
   
   I am going to close #3265 and disconnect tit from the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists