[GitHub] [accumulo] dlmarion commented on a diff in pull request #3205: Support writing cluster config parser output to a file

["dlmarion (via GitHub)" <gi...@apache.org>]

dlmarion commented on code in PR #3205:
URL: https://github.com/apache/accumulo/pull/3205#discussion_r1117807825


##########
core/src/main/java/org/apache/accumulo/core/conf/cluster/ClusterConfigParser.java:
##########
@@ -135,12 +136,23 @@ public static void outputShellVariables(Map<String,String> config, PrintStream o
     out.flush();
   }
 
+  @SuppressFBWarnings(value = "PATH_TRAVERSAL_IN",
+      justification = "Path provided for output file is intentional")
   public static void main(String[] args) throws IOException {
-    if (args == null || args.length != 1) {
-      System.err.println("Usage: ClusterConfigParser <configFile>");
+    if (args == null || args.length < 1 || args.length > 2) {
+      System.err.println("Usage: ClusterConfigParser <configFile> [<outputFile]");

Review Comment:
   ```suggestion
         System.err.println("Usage: ClusterConfigParser <configFile> [<outputFile>]");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org