You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by "Øyvind Sæbø (Jira)" <ji...@apache.org> on 2021/06/01 23:34:00 UTC

[jira] [Created] (TINKERPOP-2574) Don't gitignore package-lock.json

Øyvind Sæbø created TINKERPOP-2574:
--------------------------------------

             Summary: Don't gitignore package-lock.json
                 Key: TINKERPOP-2574
                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2574
             Project: TinkerPop
          Issue Type: Improvement
          Components: gremlint, javascript
    Affects Versions: 3.4.11, 3.3.11, 3.5.0
            Reporter: Øyvind Sæbø
            Assignee: Øyvind Sæbø
             Fix For: 3.4.11, 3.3.11, 3.5.0


Createing this task as a follow-u to https://issues.apache.org/jira/browse/TINKERPOP-2572.

To make sure the result of running npm install produces deterministic results, package-lock.json should be committed along with package.json instead of being gitignored. This will prevent older package-lock.json files that may exist locally from earlier installs from being used to determine what versions to install when running npm install.

I'm not 100% sure I understand how the Affects Version and Fix Version fields should be set when creating the Jira ticket. Feedback appreciated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)