You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/01/30 19:23:12 UTC

[GitHub] davidschreiber opened a new pull request #418: Migrate to AndroidX

davidschreiber opened a new pull request #418: Migrate to AndroidX
URL: https://github.com/apache/cordova-plugin-camera/pull/418
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   Android
   
   ### What does this PR do?
   
   Migrate to AndroidX. This plugin used a single class from the (now) deprecated Android Support Library:
   
   * The dependency to the `com.android.support:support-v4` artifact was replaced with the newer `androidx.legacy:legacy-support-v4` as suggested by the AndroidX migration guides: https://developer.android.com/jetpack/androidx/migrate
   * All use of `android.support.v4.content.FileProvider` was replaced with then newer `androidx.core.content.FileProvider` as suggested by the AndroidX migration guide.
   * The plugin property `ANDROID_SUPPORT_V4_VERSION` was replaced with a more accurately named one called `ANDROIDX_LEGACY_SUPPORT_V4_VERSION` which now defaults to `1.0.0`.
   
   ### What testing has been done on this change?
   
   Manual testing has been performed as part of reporting to the initial issue that lead to this PR: https://github.com/apache/cordova-android/issues/565
   
   ### Checklist
   - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org