[GitHub] [buildstream] gtristan commented on issue #1687: Don't add sandbox config to the cache key when BST_RUN_COMMANDS is false

[GitBox <gi...@apache.org>]

gtristan commented on issue #1687:
URL: https://github.com/apache/buildstream/issues/1687#issuecomment-1198989695

   The API promise is effective [since 1.95.0](https://lists.apache.org/thread/fm5sob2r93vrcgocg0k1lzz60kfoc63h), so technically we should not be allowed to make this change.
   
   For changes which affect cache keys pre 2.0 final I feel like we could have some leniency without anyone ever noticing.
   
   For `stack` elements there is probably no real downside to this (they cost virtually nothing to rebuild), however it may make sense if we had some way to ignore environment variables and sandbox configuration (which are two separate things) for `import` elements.
   
   If other maintainers are also open to breaking API for cache keys in advance of 2.0 (which would also be potentially useful for #1263) perhaps we could consider some feature proposal to allow certain elements to opt-out of certain cache key contributions (maybe a private API for core elements only would be appropriate).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org