Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

[Jeff Coffler <je...@taltos.com>]

> On Nov. 16, 2017, 11:34 p.m., Jie Yu wrote:
> > src/hdfs/hdfs.cpp
> > Line 119 (original), 119 (patched)
> > <https://reviews.apache.org/r/60626/diff/6/?file=1864354#file1864354line119>
> >
> >     i'd kill this line to be consistent with others.

I don't think you're looking at the latest version, I don't have this line.


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60626/#review191269
-----------------------------------------------------------


On Nov. 6, 2017, 6:09 p.m., Jeff Coffler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60626/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2017, 6:09 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, Li Li, and Michael Park.
> 
> 
> Bugs: MESOS-6705
>     https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows doesn't support os::shell calls, so reworked the code to use
> libprocess instead.
> 
> 
> Diffs
> -----
> 
>   src/hdfs/hdfs.cpp 2c95a5ea43a4289e1168c527b9ccc35690a751a4 
> 
> 
> Diff: https://reviews.apache.org/r/60626/diff/6/
> 
> 
> Testing
> -------
> 
> See upstream
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>