[GitHub] [ignite] ivandasch commented on a diff in pull request #10749: IGNITE-15629 Cache find_garbage command implemented

["ivandasch (via GitHub)" <gi...@apache.org>]

ivandasch commented on code in PR #10749:
URL: https://github.com/apache/ignite/pull/10749#discussion_r1214525702


##########
modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/persistence/db/IgniteCacheGroupsWithRestartsTest.java:
##########
@@ -348,12 +347,14 @@ private VisorFindAndDeleteGarbageInPersistenceTaskResult executeTask(
         IgniteEx ignite,
         boolean deleteFoundGarbage
     ) {
-        VisorFindAndDeleteGarbageInPersistenceTaskArg group = new VisorFindAndDeleteGarbageInPersistenceTaskArg(
-            Collections.singleton(GROUP), deleteFoundGarbage, null);
+        CacheFindGarbageCommandArg arg0 = new CacheFindGarbageCommandArg();
+
+        arg0.groups(new String[] {GROUP});
+        arg0.delete(deleteFoundGarbage);
 
         UUID id = ignite.localNode().id();
 
-        VisorTaskArgument arg = new VisorTaskArgument(id, group, true);
+        VisorTaskArgument arg = new VisorTaskArgument(id, arg0, true);

Review Comment:
   Let's move the construction of `VisorTaskArgument` to `execute(...)`, shall we?
   So it is possible to remove `arg0` to `arg`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org