You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2019/06/05 15:00:31 UTC
[GitHub] [sling-org-apache-sling-models-impl] kwin commented on issue #13:
SLING-8452 migrate to OSGi annotations
kwin commented on issue #13: SLING-8452 migrate to OSGi annotations
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/13#issuecomment-499120997
I used https://github.com/jsedding/osgi-ds-metatype-diff to compare the metadata and the output looks like this:
```
java -jar ./osgi-ds-metatype-diff-0.0.1-SNAPSHOT.jar org.apache.sling.models.impl-1.4.11-SNAPSHOT-old.jar org.apache.sling.models.impl-1.4.11-SNAPSHOT.jar
org.apache.sling.models.impl.injectors.SlingObjectInjector
Declarative Services
Properties
- service.vendor = The Apache Software Foundation (String)
- service.pid = org.apache.sling.models.impl.injectors.SlingObjectInjector (String)
org.apache.sling.models.impl.injectors.ChildResourceInjector
Declarative Services
Properties
- service.vendor = The Apache Software Foundation (String)
- service.pid = org.apache.sling.models.impl.injectors.ChildResourceInjector (String)
org.apache.sling.models.impl.injectors.ValueMapInjector
Declarative Services
Properties
- service.vendor = The Apache Software Foundation (String)
- service.pid = org.apache.sling.models.impl.injectors.ValueMapInjector (String)
org.apache.sling.models.impl.ResourceTypeBasedResourcePicker
Declarative Services
Properties
- service.vendor = The Apache Software Foundation (String)
- service.pid = org.apache.sling.models.impl.ResourceTypeBasedResourcePicker (String)
org.apache.sling.models.impl.via.ChildResourceViaProvider
Declarative Services
Properties
- service.vendor = The Apache Software Foundation (String)
- service.pid = org.apache.sling.models.impl.via.ChildResourceViaProvider (String)
org.apache.sling.models.impl.injectors.RequestAttributeInjector
Declarative Services
Properties
- service.vendor = The Apache Software Foundation (String)
- service.pid = org.apache.sling.models.impl.injectors.RequestAttributeInjector (String)
org.apache.sling.models.impl.injectors.BindingsInjector
Declarative Services
Properties
- service.vendor = The Apache Software Foundation (String)
- service.pid = org.apache.sling.models.impl.injectors.BindingsInjector (String)
org.apache.sling.models.impl.via.ResourceSuperTypeViaProvider
Declarative Services
Properties
- service.vendor = The Apache Software Foundation (String)
- service.pid = org.apache.sling.models.impl.via.ResourceSuperTypeViaProvider (String)
org.apache.sling.models.impl.injectors.ResourcePathInjector
Declarative Services
Properties
- service.vendor = The Apache Software Foundation (String)
- service.pid = org.apache.sling.models.impl.injectors.ResourcePathInjector (String)
org.apache.sling.models.impl.FirstImplementationPicker
Declarative Services
Properties
- service.vendor = The Apache Software Foundation (String)
- service.pid = org.apache.sling.models.impl.FirstImplementationPicker (String)
org.apache.sling.models.impl.via.BeanPropertyViaProvider
Declarative Services
Properties
- service.vendor = The Apache Software Foundation (String)
- service.pid = org.apache.sling.models.impl.via.BeanPropertyViaProvider (String)
org.apache.sling.models.impl.injectors.OSGiServiceInjector
Declarative Services
Properties
- service.vendor = The Apache Software Foundation (String)
- service.pid = org.apache.sling.models.impl.injectors.OSGiServiceInjector (String)
org.apache.sling.models.impl.via.ForcedResourceTypeViaProvider
Declarative Services
Properties
- service.vendor = The Apache Software Foundation (String)
- service.pid = org.apache.sling.models.impl.via.ForcedResourceTypeViaProvider (String)
org.apache.sling.models.impl.ModelAdapterFactory
Declarative Services
Properties
- service.vendor = The Apache Software Foundation (String)
- service.pid = org.apache.sling.models.impl.ModelAdapterFactory (String)
References
bindingsValuesProvidersByContext
- bind = bindBindingsValuesProvidersByContext (String)
- unbind = unbindBindingsValuesProvidersByContext (String)
+ field = bindingsValuesProvidersByContext (String)
+ field-option = replace (String)
modelValidation
- bind = bindModelValidation (String)
- unbind = unbindModelValidation (String)
+ field = modelValidation (String)
+ field-option = replace (String)
injectAnnotationProcessorFactory
- bind = bindInjectAnnotationProcessorFactory (String)
- unbind = unbindInjectAnnotationProcessorFactory (String)
+ field = injectAnnotationProcessorFactories (String)
+ field-option = replace (String)
+ field-collection = service (String)
modelExporter
- cardinality = 0..n (String)
+ cardinality = 0..1 (String)
- bind = bindModelExporter (String)
- unbind = unbindModelExporter (String)
+ field = modelExporters (String)
+ field-option = replace (String)
adapterManager
- bind = bindAdapterManager (String)
- unbind = unbindAdapterManager (String)
+ field = adapterManager (String)
+ field-option = replace (String)
staticInjectAnnotationProcessorFactory
- name = staticInjectAnnotationProcessorFactory (String)
+ name = StaticInjectAnnotationProcessorFactory (String)
injector
- name = injector (String)
+ name = Injector (String)
injectAnnotationProcessorFactory2
- bind = bindInjectAnnotationProcessorFactory2 (String)
- unbind = unbindInjectAnnotationProcessorFactory2 (String)
+ field = injectAnnotationProcessorFactories2 (String)
+ field-option = replace (String)
+ field-collection = service (String)
MetaType
Attributes
- namespace = http://www.osgi.org/xmlns/metatype/v1.0.0 (String)
+ namespace = http://www.osgi.org/xmlns/metatype/v1.2.0 (String)
Designates
org.apache.sling.models.impl.ModelAdapterFactory
- ocdRef = org.apache.sling.models.impl.ModelAdapterFactory (String)
+ ocdRef = org.apache.sling.models.impl.ModelAdapterFactoryConfiguration (String)
ObjectClassDefinitions
org.apache.sling.models.impl.ModelAdapterFactory
- id = org.apache.sling.models.impl.ModelAdapterFactory (String)
+ id = org.apache.sling.models.impl.ModelAdapterFactoryConfiguration (String)
- description = Description for org.apache.sling.models.impl.ModelAdapterFactory (String)
+ description = (String)
Attribute Definitions
cleanup.job.period
- description = Period at which OSGi service references from ThreadLocals will be cleaned up. (String)
+ description = Period in seconds at which OSGi service references from ThreadLocals will be cleaned up. (String)
osgi.http.whiteboard.listener
- id = osgi.http.whiteboard.listener (String)
- name = Property osgi.http.whiteboard.listener (String)
- description = Description for osgi.http.whiteboard.listener (String)
- type = 1 (Integer)
- cardinality = 0 (Integer)
- defaultValue = [true] (String[])
- optionLabels = [] (String[])
- optionValues = [] (String[])
osgi.http.whiteboard.context.select
- id = osgi.http.whiteboard.context.select (String)
- name = Property osgi.http.whiteboard.context.select (String)
- description = Description for osgi.http.whiteboard.context.select (String)
- type = 1 (Integer)
- cardinality = 0 (Integer)
- defaultValue = [(osgi.http.whiteboard.context.name=*)] (String[])
- optionLabels = [] (String[])
- optionValues = [] (String[])
org.apache.sling.models.impl.injectors.SelfInjector
Declarative Services
Properties
- service.vendor = The Apache Software Foundation (String)
- service.pid = org.apache.sling.models.impl.injectors.SelfInjector (String)
```
So most of the differences are due to the missing service.vendor and obsolete service.pid as well as some metadata which should not be exposed as such.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services