You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/01/06 23:12:01 UTC
[GitHub] [netbeans] BradWalker opened a new pull request #1852:
[NETBEANS-3670] - cleanup addElement() unchecked calls
BradWalker opened a new pull request #1852: [NETBEANS-3670] - cleanup addElement() unchecked calls
URL: https://github.com/apache/netbeans/pull/1852
Cleanup a bunch of warnings related to uncheck call to addEelement()
[repeat] /home/bwalker/src/netbeans/platform/api.progress/src/org/netbeans/modules/progress/spi/TaskModel.java:67: warning: [unchecked] unchecked call to addElement(E) as a member of the raw type DefaultListModel
[repeat] model.addElement(handle);
[repeat] ^
[repeat] where E is a type-variable:
[repeat] E extends Object declared in class DefaultListModel
[repeat] 1 warning
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#1852: [NETBEANS-3670] - cleanup addElement() unchecked calls
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #1852: [NETBEANS-3670] - cleanup addElement() unchecked calls
URL: https://github.com/apache/netbeans/pull/1852#discussion_r363911076
##########
File path: ide/versioning.ui/src/org/netbeans/modules/versioning/ui/options/GeneralOptionsPanel.java
##########
@@ -29,6 +29,7 @@
import java.util.HashMap;
import java.util.LinkedList;
import java.util.List;
+import javax.swing.ListModel;
Review comment:
Looks unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #1852:
[NETBEANS-3670] - cleanup addElement() unchecked calls
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #1852: [NETBEANS-3670] - cleanup addElement() unchecked calls
URL: https://github.com/apache/netbeans/pull/1852
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #1852:
[NETBEANS-3670] - cleanup addElement() unchecked calls
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #1852: [NETBEANS-3670] - cleanup addElement() unchecked calls
URL: https://github.com/apache/netbeans/pull/1852#issuecomment-571748250
Could you please recheck this? You pulled in changes from two other authors, rebased these onto your change and pushed that. Please rebase your changes onto master, that way you get a clean change again, with only your changed. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #1852:
[NETBEANS-3670] - cleanup addElement() unchecked calls
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #1852: [NETBEANS-3670] - cleanup addElement() unchecked calls
URL: https://github.com/apache/netbeans/pull/1852#discussion_r363922151
##########
File path: ide/versioning.ui/src/org/netbeans/modules/versioning/ui/options/GeneralOptionsPanel.java
##########
@@ -29,6 +29,7 @@
import java.util.HashMap;
import java.util.LinkedList;
import java.util.List;
+import javax.swing.ListModel;
Review comment:
ditto..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on issue #1852: [NETBEANS-3670] -
cleanup addElement() unchecked calls
Posted by GitBox <gi...@apache.org>.
BradWalker commented on issue #1852: [NETBEANS-3670] - cleanup addElement() unchecked calls
URL: https://github.com/apache/netbeans/pull/1852#issuecomment-571749351
Ugg.. Fixed..
Sorry about that!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#1852: [NETBEANS-3670] - cleanup addElement() unchecked calls
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #1852: [NETBEANS-3670] - cleanup addElement() unchecked calls
URL: https://github.com/apache/netbeans/pull/1852#discussion_r363909861
##########
File path: ide/project.ant.ui/src/org/netbeans/spi/project/support/ant/ui/LicenseHeadersPanel.java
##########
@@ -22,6 +22,7 @@
import java.awt.event.ActionListener;
import java.io.IOException;
import javax.swing.Action;
+import javax.swing.ListModel;
Review comment:
Looks unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #1852:
[NETBEANS-3670] - cleanup addElement() unchecked calls
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #1852: [NETBEANS-3670] - cleanup addElement() unchecked calls
URL: https://github.com/apache/netbeans/pull/1852#discussion_r363922086
##########
File path: ide/project.ant.ui/src/org/netbeans/spi/project/support/ant/ui/LicenseHeadersPanel.java
##########
@@ -22,6 +22,7 @@
import java.awt.event.ActionListener;
import java.io.IOException;
import javax.swing.Action;
+import javax.swing.ListModel;
Review comment:
good eyes.. I sometimes miss things like this since I'm editing so many files at once..
thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists