You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2022/11/03 22:41:40 UTC

[GitHub] [datasketches-cpp] jmalkin opened a new pull request, #318: Common version

jmalkin opened a new pull request, #318:
URL: https://github.com/apache/datasketches-cpp/pull/318

   * Bump versions for actions in workflows
   * Define `version.cfg.in` as a single point to specify version
   * Supporting changes to use the generated version
   
   For dev builds, version will be major.minor.@DT@.@HHMM@ where they're expanded into the current UTC date and hour/minute. For releases, we'll specify the exact version number and the code to replace those variables will have nothing to do. But this should give us only one place to change the version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] will-lauer commented on a diff in pull request #318: Common version

Posted by GitBox <gi...@apache.org>.
will-lauer commented on code in PR #318:
URL: https://github.com/apache/datasketches-cpp/pull/318#discussion_r1015731454


##########
.gitignore:
##########
@@ -1,3 +1,7 @@
+# output of configured files
+version.cfg
+common/include/version.hpp

Review Comment:
   generally, I wouldn't suggest creating the version.hpp file in the common/include directory, but rather in the build directory.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] coveralls commented on pull request #318: Common version

Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #318:
URL: https://github.com/apache/datasketches-cpp/pull/318#issuecomment-1302762693

   ## Pull Request Test Coverage Report for [Build 3389843747](https://coveralls.io/builds/53898136)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **93.959%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/53898136/badge)](https://coveralls.io/builds/53898136) |
   | :-- | --: |
   | Change from base [Build 3381882666](https://coveralls.io/builds/53862301): |  0.0% |
   | Covered Lines: | 2224 |
   | Relevant Lines: | 2367 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] AlexanderSaydakov commented on a diff in pull request #318: Common version

Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov commented on code in PR #318:
URL: https://github.com/apache/datasketches-cpp/pull/318#discussion_r1013481687


##########
CMakeLists.txt:
##########
@@ -16,10 +16,24 @@
 # under the License.
 
 cmake_minimum_required(VERSION 3.16.0)
+
+string(TIMESTAMP DT %Y%m%d UTC)
+string(TIMESTAMP HHMM %H%M UTC)
+configure_file(version.cfg.in ${CMAKE_CURRENT_SOURCE_DIR}/version.cfg @ONLY)
+file(STRINGS version.cfg BASE_VERSION)
+
 project(DataSketches
-        VERSION 3.6.0
+        VERSION ${BASE_VERSION}
         LANGUAGES CXX)
 
+#get_cmake_property(_variableNames VARIABLES)

Review Comment:
   do we need to keep this commented-out section?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] jmalkin merged pull request #318: Common version

Posted by GitBox <gi...@apache.org>.
jmalkin merged PR #318:
URL: https://github.com/apache/datasketches-cpp/pull/318


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] jmalkin commented on a diff in pull request #318: Common version

Posted by GitBox <gi...@apache.org>.
jmalkin commented on code in PR #318:
URL: https://github.com/apache/datasketches-cpp/pull/318#discussion_r1015740131


##########
.gitignore:
##########
@@ -1,3 +1,7 @@
+# output of configured files
+version.cfg
+common/include/version.hpp

Review Comment:
   what about version.cfg?  and will it be picked up by make install if it's only in the build directory? i guess it should...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] jmalkin commented on a diff in pull request #318: Common version

Posted by GitBox <gi...@apache.org>.
jmalkin commented on code in PR #318:
URL: https://github.com/apache/datasketches-cpp/pull/318#discussion_r1015922588


##########
common/include/version.hpp.in:
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#ifndef _VERSION_HPP_
+#define _VERSION_HPP_
+
+namespace datasketches {
+
+// the configured options and settings for DataSketches
+constexpr int VERSION_MAJOR {@DataSketches_VERSION_MAJOR@};
+constexpr int VERSION_MINOR {@DataSketches_VERSION_MINOR@};
+constexpr int VERSION_PATCH {@DataSketches_VERSION_PATCH@};
+constexpr int VERSION_TWEAK {@DataSketches_VERSION_TWEAK@};
+
+constexpr auto VERSION_STR = "@DataSketches_VERSION@";
+constexpr auto SOURCE_URL = "https://github.com/apache/datasketches-cpp";
+
+}
+
+#endif // _VERSION_HPP_

Review Comment:
   fix, thx



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] jmalkin commented on a diff in pull request #318: Common version

Posted by GitBox <gi...@apache.org>.
jmalkin commented on code in PR #318:
URL: https://github.com/apache/datasketches-cpp/pull/318#discussion_r1013487650


##########
CMakeLists.txt:
##########
@@ -16,10 +16,24 @@
 # under the License.
 
 cmake_minimum_required(VERSION 3.16.0)
+
+string(TIMESTAMP DT %Y%m%d UTC)
+string(TIMESTAMP HHMM %H%M UTC)
+configure_file(version.cfg.in ${CMAKE_CURRENT_SOURCE_DIR}/version.cfg @ONLY)
+file(STRINGS version.cfg BASE_VERSION)
+
 project(DataSketches
-        VERSION 3.6.0
+        VERSION ${BASE_VERSION}
         LANGUAGES CXX)
 
+#get_cmake_property(_variableNames VARIABLES)

Review Comment:
   Removed -- thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] will-lauer commented on a diff in pull request #318: Common version

Posted by GitBox <gi...@apache.org>.
will-lauer commented on code in PR #318:
URL: https://github.com/apache/datasketches-cpp/pull/318#discussion_r1015917716


##########
common/include/version.hpp.in:
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#ifndef _VERSION_HPP_
+#define _VERSION_HPP_
+
+namespace datasketches {
+
+// the configured options and settings for DataSketches
+constexpr int VERSION_MAJOR {@DataSketches_VERSION_MAJOR@};
+constexpr int VERSION_MINOR {@DataSketches_VERSION_MINOR@};
+constexpr int VERSION_PATCH {@DataSketches_VERSION_PATCH@};
+constexpr int VERSION_TWEAK {@DataSketches_VERSION_TWEAK@};
+
+constexpr auto VERSION_STR = "@DataSketches_VERSION@";
+constexpr auto SOURCE_URL = "https://github.com/apache/datasketches-cpp";
+
+}
+
+#endif // _VERSION_HPP_

Review Comment:
   missing newline?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] jmalkin commented on a diff in pull request #318: Common version

Posted by GitBox <gi...@apache.org>.
jmalkin commented on code in PR #318:
URL: https://github.com/apache/datasketches-cpp/pull/318#discussion_r1015915382


##########
.gitignore:
##########
@@ -1,3 +1,7 @@
+# output of configured files
+version.cfg
+common/include/version.hpp

Review Comment:
   should be fixed now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org