[GitHub] [iceberg] stevenzwu commented on pull request #5348: API: define Gauge and Histogram metrics with default implementations

[GitBox <gi...@apache.org>]

stevenzwu commented on PR #5348:
URL: https://github.com/apache/iceberg/pull/5348#issuecomment-1199796399

   Had a discussion with @rdblue. 
   
   Iceberg `MetricContext` should be used as a way for iceberg-core to expose metrics. Engine specific metrics (like Flink reader or writer) don't need to add an indirection and translate from Iceberg `MetricContext` to Flink metrics. There is not much benefit for the indirection. 
   
   For that reason, I will remove the `Gauge` metric from this PR. I will also send another PR for Flink FLIP-27 source, which currently translate from Iceberg `MetricsContext` to Flink metrics.
   
   For simplicity, we will remove the `reservoirSize` param from `MetricsContext#histogram(name)` and hard-code the reservoirSize (probably to 1,024) for now. In the future, when we want to provide more flexibility, maybe we can add a new interface (like `ObservationsTracker`) that allows users to specify the data structure for tracking observations (e.g. FixedReservoirTracker, SketchTracker, etc.)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org