[GitHub] [tvm] Hzfengsy commented on a diff in pull request #12589: [TIR] Expose WMMA-related TensorCore builtins

[GitBox <gi...@apache.org>]

Hzfengsy commented on code in PR #12589:
URL: https://github.com/apache/tvm/pull/12589#discussion_r954503706


##########
python/tvm/tir/op.py:
##########
@@ -595,6 +595,242 @@ def tvm_throw_last_error():
     return call_intrin("handle", "tir.tvm_throw_last_error")
 
 
+def tvm_load_matrix_sync(fragment, m, n, k, index, buffer_ptr, stride, layout):
+    """TVM intrinsic for tensor core load operators
+
+    Parameters
+    ----------
+    fragment : Var
+        The wmma fragment.
+
+    m : UIntImm
+        The shape of wmma fragment.
+
+    n : UIntImm
+        The shape of wmma fragment.
+
+    k : UIntImm
+        The shape of wmma fragment.
+
+    index : Expr
+        The fragment index.
+
+    buffer_ptr : Expr
+        The fragment buffer pointer.
+
+    stride : Expr
+        The fragment stride.
+
+    layout : StringImm

Review Comment:
   Could you please use `Literal` [docs here](https://docs.python.org/3/library/typing.html#typing.Literal) to indicate which str is valid?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org