You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "mlsorensen (via GitHub)" <gi...@apache.org> on 2023/03/22 17:40:38 UTC
[GitHub] [cloudstack-go] mlsorensen opened a new pull request, #52: Do value encoding in EncodeValues, add tests
mlsorensen opened a new pull request, #52:
URL: https://github.com/apache/cloudstack-go/pull/52
Similar to #49 - however we push the customizations to value encoding into `EncodeValues` function, and add tests for this function.
Adding Ginkgo/Gomega for table support in test suites, this adds a lot of dependencies but also provides for a richer test framework. We can omit this and I can refactor the tests to be simpler if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] mlsorensen commented on pull request #52: Do value encoding in EncodeValues, add tests
Posted by "mlsorensen (via GitHub)" <gi...@apache.org>.
mlsorensen commented on PR #52:
URL: https://github.com/apache/cloudstack-go/pull/52#issuecomment-1488961731
Tested manually as well, first ensured spaces still get encoded to `%20` instead of `+` by setting `custom.cs.identifier` to `my cloudstack`
```
params := client.Configuration.NewUpdateConfigurationParams("custom.cs.identifier")
params.SetValue("my cloudstack")
response, err := client.Configuration.UpdateConfiguration(params)
```
API Log:
```
GET apiKey=xxxx&command=updateConfiguration&name=custom.cs.identifier&response=json&value=my%20cloudstack&signature=xxxx 200 {"updateconfigurationresponse":{"configuration":{"category":"Advanced","name":"custom.cs.identifier","value":"my cloudstack","description":"Custom identifier for the cloudstack installation","isdynamic":true}}}
```
Tested using asterisk in `consoleproxy.url.domain` by setting to `*.turboio.com`:
```
params := client.Configuration.NewUpdateConfigurationParams("consoleproxy.url.domain")
params.SetValue("*.turboio.com")
response, err := client.Configuration.UpdateConfiguration(params)
```
API Log:
```
GET apiKey=xxxx&command=updateConfiguration&name=consoleproxy.url.domain&response=json&value=*.turboio.com&signature=xxxx 200 {"updateconfigurationresponse":{"configuration":{"category":"Console Proxy","name":"consoleproxy.url.domain","value":"*.turboio.com","description":"Console proxy url domain","isdynamic":false}}}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] mlsorensen commented on pull request #52: Do value encoding in EncodeValues, add tests
Posted by "mlsorensen (via GitHub)" <gi...@apache.org>.
mlsorensen commented on PR #52:
URL: https://github.com/apache/cloudstack-go/pull/52#issuecomment-1488965942
While two thumbs up is good enough for Siskel and Ebert, I'll give some more time for committers to review/reply before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] rohityadavcloud merged pull request #52: Do value encoding in EncodeValues, add tests
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #52:
URL: https://github.com/apache/cloudstack-go/pull/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org