[GitHub] spark pull request #18093: [WIP][SPARK-20774][SQL] Cancel all jobs when Quer...

[markhamstra <gi...@git.apache.org>]

Github user markhamstra commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18093#discussion_r129382985
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
    @@ -89,8 +91,22 @@ class QueryExecution(val sparkSession: SparkSession, val logical: LogicalPlan) {
       lazy val executedPlan: SparkPlan = prepareForExecution(sparkPlan)
     
       /** Internal version of the RDD. Avoids copies and has no schema */
    -  lazy val toRdd: RDD[InternalRow] = executedPlan.execute()
    +  lazy val toRdd: RDD[InternalRow] = executePlan()
     
    +  private def executePlan(): RDD[InternalRow] = {
    +    sparkSession.sparkContext.setJobGroup(runId.toString, getDescriptionString,
    --- End diff --
    
    Wait... aren't you clobbering any JobGroup that is already set?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org