You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Torsten Krah (JIRA)" <ji...@apache.org> on 2012/06/26 12:08:44 UTC
[jira] [Updated] (LUCENE-4165) HunspellDictionary - AffixFile
Reader closed, Dictionary Readers left unclosed
[ https://issues.apache.org/jira/browse/LUCENE-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Torsten Krah updated LUCENE-4165:
---------------------------------
Attachment: lucene_36.patch
lucene_trunk.patch
- Patch against trunk and 3.6.
- Resources are closed asap.
- Finally block in constructor added to be sure resources are closed too if an exception is hit before resources are processed.
- Test modified to check if close() was called on the provided streams after the Dictionary constructor was called.
> HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed
> ------------------------------------------------------------------------------
>
> Key: LUCENE-4165
> URL: https://issues.apache.org/jira/browse/LUCENE-4165
> Project: Lucene - Java
> Issue Type: Bug
> Components: modules/analysis
> Affects Versions: 3.6
> Environment: Linux, Java 1.6
> Reporter: Torsten Krah
> Priority: Minor
> Attachments: lucene_36.patch, lucene_trunk.patch
>
>
> The HunspellDictionary takes an InputStream for affix file and a List of Streams for dictionaries.
> Javadoc is not clear about i have to close those stream myself or the Dictionary constructor does this already.
> Looking at the code, at least reader.close() is called when the affix file is read via readAffixFile() method (although closing streams is not done in a finally block - so the constructor may fail to do so).
> The readDictionaryFile() method does miss the call to close the reader in contrast to readAffixFile().
> So the question here is - have i have to close the streams myself after instantiating the dictionary?
> Or is the close call only missing for the dictionary streams?
> Either way, please add the close calls in a safe manner or clarify javadoc so i have to do this myself.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org