You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Rodrigo Schmidt (JIRA)" <ji...@apache.org> on 2010/04/08 04:17:36 UTC
[jira] Created: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
FilterFileSystem doesn't overwrite setTimes
-------------------------------------------
Key: HADOOP-6690
URL: https://issues.apache.org/jira/browse/HADOOP-6690
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 0.20.3, 0.21.0, 0.22.0
Reporter: Rodrigo Schmidt
Fix For: 0.22.0
FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
- setTimes(Path, long, long)
- copyFromLocalFile(boolean,boolean, Path, Path)
- copyFromLocalFile(boolean, boolean, Path[], Path)
- getUsed()
- deleteOnExit()
I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854810#action_12854810 ]
Rodrigo Schmidt commented on HADOOP-6690:
-----------------------------------------
Is FilterFs supposed to suppress FilterFileSystem? When was it introduced?
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.20.3, 0.21.0, 0.22.0
> Reporter: Rodrigo Schmidt
> Fix For: 0.22.0
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-6690:
-------------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
I just committed this. Thanks Rodrigo!
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6690.0.patch, HADOOP-6690.1.patch, HADOOP-6690.2.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6690:
------------------------------------
Status: Open (was: Patch Available)
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6690.0.patch, HADOOP-6690.1.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6690:
------------------------------------
Attachment: HADOOP-6690.1.patch
New patch without any warnings.
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6690.0.patch, HADOOP-6690.1.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6690:
------------------------------------
Attachment: HADOOP-6690.0.patch
Uploading patch
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.20.3, 0.21.0, 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6690.0.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859196#action_12859196 ]
Hadoop QA commented on HADOOP-6690:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12442393/HADOOP-6690.2.patch
against trunk revision 934619.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/46/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/46/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/46/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/46/console
This message is automatically generated.
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6690.0.patch, HADOOP-6690.1.patch, HADOOP-6690.2.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859113#action_12859113 ]
Rodrigo Schmidt commented on HADOOP-6690:
-----------------------------------------
The warnings are generated because the methods of the DontCheck class are used by reflection. I'll silence these warnings in my next patch, but I'm not sure if Hadoop QA won't complain about that.
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6690.0.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859141#action_12859141 ]
Rodrigo Schmidt commented on HADOOP-6690:
-----------------------------------------
Eli, while I was creating TestFilterFs, I realized there was a number of methods that were not being implemented. Some of them are quite suspicious like getUri(), getStatistics(), getHomeDirectory(), ... Can you please double check if FilterFs is fine without these methods. If it's not the case, it would be better to create a separate JIRA for that.
Here is the complete list:
{code}
{
public FSDataInputStream open(final Path f) { return null; }
public void checkPath(Path path) { }
public Statistics getStatistics() { return null; }
public URI getUri() { return null; }
public Path getHomeDirectory() { return null; }
public void checkScheme(URI uri, String supportedScheme) { }
public String getUriPath(final Path p) { return null; }
public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
public FsStatus getFsStatus(final Path f) { return null; }
}
{code}
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6690.0.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859031#action_12859031 ]
Eli Collins commented on HADOOP-6690:
-------------------------------------
+1 Patch looks good. Mind adding TestFilterFs that's a FilterFs equivalent to TestFilterFileSystem? Should be an pretty easy port.
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6690.0.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854831#action_12854831 ]
Eli Collins commented on HADOOP-6690:
-------------------------------------
FilterFs is the AbstractFileSystem version of FilterFileSystem. If you're doing work on trunk you should be writing against the new APIs (or at least make sure they stay on par), if you're making a change against branch 20 then you'll want FilterFileSystem. I'm assuming you want setTimes to work on LocalFileSystem?
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.20.3, 0.21.0, 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6690:
------------------------------------
Attachment: (was: HADOOP-6690.1.patch)
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6690.0.patch, HADOOP-6690.1.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6690:
------------------------------------
Status: Open (was: Patch Available)
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6690.0.patch, HADOOP-6690.1.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt reassigned HADOOP-6690:
---------------------------------------
Assignee: Rodrigo Schmidt
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.20.3, 0.21.0, 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854841#action_12854841 ]
Eli Collins commented on HADOOP-6690:
-------------------------------------
Having FilterFileSystem override setTimes (and other APIs) is very reasonable. Just pointing out the new APIs in case you were doing trunk work. We'll want to move contrib/raid off FileSystem as part of HADOOP-6446.
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.20.3, 0.21.0, 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6690:
------------------------------------
Status: Patch Available (was: Open)
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6690.0.patch, HADOOP-6690.1.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6690:
------------------------------------
Status: Patch Available (was: Open)
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6690.0.patch, HADOOP-6690.1.patch, HADOOP-6690.2.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859169#action_12859169 ]
Hadoop QA commented on HADOOP-6690:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12442377/HADOOP-6690.1.patch
against trunk revision 934619.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 1028 javac compiler warnings (more than the trunk's current 1024 warnings).
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/467/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/467/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/467/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/467/console
This message is automatically generated.
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6690.0.patch, HADOOP-6690.1.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6690:
------------------------------------
Attachment: HADOOP-6690.1.patch
New patch without any warnings.
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6690.0.patch, HADOOP-6690.1.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859089#action_12859089 ]
Rodrigo Schmidt commented on HADOOP-6690:
-----------------------------------------
Sure! I can do that. I'll update the patch later today.
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6690.0.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859107#action_12859107 ]
Hadoop QA commented on HADOOP-6690:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12442315/HADOOP-6690.0.patch
against trunk revision 934619.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 1028 javac compiler warnings (more than the trunk's current 1024 warnings).
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/466/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/466/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/466/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/466/console
This message is automatically generated.
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6690.0.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854843#action_12854843 ]
Rodrigo Schmidt commented on HADOOP-6690:
-----------------------------------------
Sure! Thanks for the hint, BTW.
With respect to HADOOP-6446, I should be able to help with Raid/Har/DistCp as soon as I'm done with some critical raid patches.
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.20.3, 0.21.0, 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854796#action_12854796 ]
Eli Collins commented on HADOOP-6690:
-------------------------------------
Can you use FilterFs? It has setTimes.
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.20.3, 0.21.0, 0.22.0
> Reporter: Rodrigo Schmidt
> Fix For: 0.22.0
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854834#action_12854834 ]
Rodrigo Schmidt commented on HADOOP-6690:
-----------------------------------------
I noticed the problem when using contrib/raid, which currently relies on FilterFileSystem (because it was originally implemented on hadoop 0.20). Maybe we should change the trunk version to work with FilterFs.
However, this workaround doesn't make FilterFileSystem more correct. We should either fix it or deprecate it so that people don't feel compelled to use it in the future. What do you think?
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.20.3, 0.21.0, 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859197#action_12859197 ]
dhruba borthakur commented on HADOOP-6690:
------------------------------------------
+1 thanks, I will commit this patch.
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6690.0.patch, HADOOP-6690.1.patch, HADOOP-6690.2.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859153#action_12859153 ]
Rodrigo Schmidt commented on HADOOP-6690:
-----------------------------------------
I was talking to Dhruba and we thought it would be better to create a new issue to discuss the methods missing on FilterFs() and its unit test. I just created HADOOP-6719 for that.
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6690.0.patch, HADOOP-6690.1.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6690:
------------------------------------
Attachment: HADOOP-6690.2.patch
Found a couple of more warnings.
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6690.0.patch, HADOOP-6690.1.patch, HADOOP-6690.2.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6690) FilterFileSystem doesn't overwrite
setTimes
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6690:
------------------------------------
Status: Patch Available (was: Open)
Affects Version/s: (was: 0.21.0)
(was: 0.20.3)
> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
> Key: HADOOP-6690
> URL: https://issues.apache.org/jira/browse/HADOOP-6690
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6690.0.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods (setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given its purpose, I would say the more the better. It would be great to have other people's opinions about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.