[GitHub] [incubator-superset] robdiciuccio commented on a change in pull request #12049: feat: show missing parameters in query

[GitBox <gi...@apache.org>]

robdiciuccio commented on a change in pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#discussion_r546041615



##########
File path: superset/jinja_context.py
##########
@@ -296,7 +297,7 @@ def __init__(
             self._schema = table.schema
         self._extra_cache_keys = extra_cache_keys
         self._context: Dict[str, Any] = {}
-        self._env = SandboxedEnvironment()
+        self._env = SandboxedEnvironment(undefined=DebugUndefined)

Review comment:
       Is `DebugUndefined` required to make `find_undeclared_variables` function? Doesn't seem to be a requirement in the docs.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org