[GitHub] [beam] Dobiasd commented on a change in pull request #15087: [BEAM-12544] Add support for Avro timestamps in microseconds

[GitBox <gi...@apache.org>]

Dobiasd commented on a change in pull request #15087:
URL: https://github.com/apache/beam/pull/15087#discussion_r659135263



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/AvroUtils.java
##########
@@ -765,8 +765,8 @@ private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundE
       if (logicalType instanceof LogicalTypes.Decimal) {
         fieldType = FieldType.DECIMAL;
       } else if (logicalType instanceof LogicalTypes.TimestampMillis) {
-        // TODO: There is a desire to move Beam schema DATETIME to a micros representation. When

Review comment:
       This is unrelated to the representation of Beam schema `DATETIME`. The correct TODO comment for this is here: https://github.com/apache/beam/blob/961cf0936d7065bf6089e666fbbc6b83da266df2/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/AvroUtils.java#L883-L884




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org