[jira] [Comment Edited] (HBASE-27474) Evict blocks on split/merge; Avoid caching reference/hlinks if compaction is enabled

["Bryan Beaudreault (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-27474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649934#comment-17649934 ] 

Bryan Beaudreault edited comment on HBASE-27474 at 12/20/22 6:53 PM:
---------------------------------------------------------------------

[~wchevreuil] this caused spotless issues in RSRpcServices for branch-2. Would you mind committing an addendum?


was (Author: bbeaudreault):
[~wchevreuil] this caused spotless issues in RSRpcServices. Would you mind committing an addendum?

> Evict blocks on split/merge; Avoid caching reference/hlinks if compaction is enabled
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-27474
>                 URL: https://issues.apache.org/jira/browse/HBASE-27474
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 3.0.0-alpha-3
>            Reporter: Wellington Chevreuil
>            Assignee: Wellington Chevreuil
>            Priority: Major
>             Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> This change aims to improve block cache usage upon splits/merges. On a split/merge event the following main steps happen:
> 1) parent regions are closed; 2) daughters are created and opened with refs/hlinks; 3) Compaction is triggered soon after the daughters get online;
> With "hbase.rs.evictblocksonclose" set to false, we keep all blocks for the closed regions in 1, then will try to load same blocks again on 2 (since we are using the refs/links for the cache key), just to throw it away and cache the compaction resulting file in 3. 
> If the block cache is close to its capacity, blocks from the compacted files in 3 will likely miss the cache.
> The proposal here is to always evict blocks for parent regions on a split/merge event, and also avoid caching blocks for refs/hlinks if compactions are enabled. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)