You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/02/17 19:18:56 UTC

[GitHub] [buildstream] nanonyme commented on a change in pull request #1547: Pure python cython

nanonyme commented on a change in pull request #1547:
URL: https://github.com/apache/buildstream/pull/1547#discussion_r809387795



##########
File path: src/buildstream/_types.py
##########
@@ -72,11 +73,11 @@ def set_values(mcs, kls, data):
 
         type.__setattr__(kls, "_value_to_entry", value_to_entry)
 
-    def __repr__(self):
-        return "<fastenum '{}'>".format(self.__name__)
+    def __repr__(cls):

Review comment:
       Looks weird. This looks like it assumes it's a class method but there's no classmethod decorator.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org