You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2008/09/17 11:20:06 UTC

DO NOT REPLY [Bug 45823] New: AccessLogValve doesn't correctly handles combined log format (with patch)

https://issues.apache.org/bugzilla/show_bug.cgi?id=45823

           Summary: AccessLogValve doesn't correctly handles combined log
                    format (with patch)
           Product: Tomcat 6
           Version: 6.0.16
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: per.landberg@polago.se


Created an attachment (id=22595)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22595)
Patch that corrects this bug

When configuring the AccessLogValve valve to use the combined log format and
either referer or user-agent fields are unavailable in the request, the
corresponding log entry fields will contain "(null)" instead of "-". This
behaviour breaks access log analyzers like AWStats and I believe it's also a
violation of the log spec.

Included is a patch that I believe will correct the problem. The patch make
sure that any non-existing header will be logged as '-' instead of trying to
log a null pointer.

I stumbled on this problem when upgrading from Tomcat 5.5 to 6.0.16 using
Debian etch and JDK 6. Tomcat 5.5 didn't suffer from this issue.

I haven't yet tried Tomcat 6.0.18 but the AccessLogValve.java file seems to be
unchanged between the two releases so I suspect the problem still exists.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 45823] AccessLogValve doesn't correctly handles combined log format (with patch)

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45823


Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Mark Thomas <ma...@apache.org>  2008-09-19 04:06:37 PST ---
This has been committed to 6.0.x and will be included in 6.0.19 onwards.

Thanks again for the patch.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 45823] AccessLogValve doesn't correctly handles combined log format (with patch)

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45823





--- Comment #1 from Mark Thomas <ma...@apache.org>  2008-09-17 03:58:39 PST ---
Thanks for the report and the patch. I have applied a slightly modified patch
to trunk and proposed it for 6.0.x.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org