You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/18 11:40:04 UTC
[jira] [Commented] (DRILL-5523) Revert if condition in
UnionAllRecordBatch changed in DRILL-5419
[ https://issues.apache.org/jira/browse/DRILL-5523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015621#comment-16015621 ]
ASF GitHub Bot commented on DRILL-5523:
---------------------------------------
GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/842
DRILL-5523: Revert if condition in UnionAllRecordBatch changed in DRI…
…LL-5419
If condition in UnionAllRecordBatch which was changed to correct one in DRILL-5419 but this change caused the regression (DRILL-5521).
The root cause is not in change itself but rather in missing indication of child column in map types when it is null. There is a big project upcoming re-working json reader implementation, including map types (DRILL-4824) which will fix the problem.
So far reverting change to initial state so users won't see the regression till DRILL-4824 is merged.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arina-ielchiieva/drill DRILL-5523
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/842.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #842
----
----
> Revert if condition in UnionAllRecordBatch changed in DRILL-5419
> ----------------------------------------------------------------
>
> Key: DRILL-5523
> URL: https://issues.apache.org/jira/browse/DRILL-5523
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.11.0
> Reporter: Arina Ielchiieva
> Assignee: Arina Ielchiieva
> Fix For: 1.11.0
>
>
> If condition in UnionAllRecordBatch which was changed to correct one in DRILL-5419 but this change caused the regression (DRILL-5521).
> The root cause is not in change itself but rather in missing indication of child column in map types when it is null. There is a big project upcoming to re-working json reader implementation, including map types (DRILL-4824) which will fix the problem.
> So far reverting change to previous one so users won't see the regression till DRILL-4824 is merged.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)