You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Gabriella Lotz (Code Review)" <ge...@cloudera.org> on 2026/09/16 12:46:47 UTC
[kudu-CR] KUDU-3761 drop default for prefer follower moves
Gabriella Lotz has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24863
Change subject: KUDU-3761 drop default for prefer_follower_moves
......................................................................
KUDU-3761 drop default for prefer_follower_moves
LocationBalancingAlgo requires callers to pass
'prefer_follower_moves' explicitly. TwoDimensionalGreedyAlgo
still defaulted it to true, so callers could quietly opt into
follower-preferring behavior by leaving the arg off.
Drop that default. The trailing EqualSkewOption default goes
with it (defaults must be contiguous at the end); update the
zero/one-arg call sites in rebalance_algo-test.cc to pass both
args.
Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
---
M src/kudu/rebalance/rebalance_algo-test.cc
M src/kudu/rebalance/rebalance_algo.h
2 files changed, 29 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/24863/1
--
To view, visit http://gerrit.cloudera.org:8080/24863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Gerrit-Change-Number: 24863
Gerrit-PatchSet: 1
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
[kudu-CR] KUDU-3761 drop default for prefer follower moves
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24863 )
Change subject: KUDU-3761 drop default for prefer_follower_moves
......................................................................
Patch Set 3:
Build Aborted
http://jenkins.kudu.apache.org/job/pre_commit/3012/ : ABORTED
--
To view, visit http://gerrit.cloudera.org:8080/24863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Gerrit-Change-Number: 24863
Gerrit-PatchSet: 3
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Sep 2026 00:14:05 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3761 drop default for prefer follower moves
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24863 )
Change subject: KUDU-3761 drop default for prefer_follower_moves
......................................................................
KUDU-3761 drop default for prefer_follower_moves
LocationBalancingAlgo requires callers to pass
'prefer_follower_moves' explicitly. TwoDimensionalGreedyAlgo
still defaulted it to true, so callers could quietly opt into
follower-preferring behavior by leaving the arg off.
Drop that default. The trailing EqualSkewOption default goes
with it (defaults must be contiguous at the end); update the
zero/one-arg call sites in rebalance_algo-test.cc to pass both
args.
Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Reviewed-on: http://gerrit.cloudera.org:8080/24863
Reviewed-by: Ashwani Raina <ar...@gmail.com>
Reviewed-by: Marton Greber <gr...@gmail.com>
Tested-by: Marton Greber <gr...@gmail.com>
---
M src/kudu/rebalance/rebalance_algo-test.cc
M src/kudu/rebalance/rebalance_algo.h
2 files changed, 37 insertions(+), 12 deletions(-)
Approvals:
Ashwani Raina: Looks good to me, approved
Marton Greber: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/24863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Gerrit-Change-Number: 24863
Gerrit-PatchSet: 5
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-3761 drop default for prefer follower moves
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24863 )
Change subject: KUDU-3761 drop default for prefer_follower_moves
......................................................................
Patch Set 4: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/3033/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/24863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Gerrit-Change-Number: 24863
Gerrit-PatchSet: 4
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Sep 2026 17:27:18 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3761 drop default for prefer follower moves
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24863 )
Change subject: KUDU-3761 drop default for prefer_follower_moves
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/2997/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/24863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Gerrit-Change-Number: 24863
Gerrit-PatchSet: 2
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 21 Sep 2026 08:02:12 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3761 drop default for prefer follower moves
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24863 )
Change subject: KUDU-3761 drop default for prefer_follower_moves
......................................................................
Patch Set 2:
(3 comments)
Thank you addressing this.
Overall looks good to me.
Just a few nits/questions.
http://gerrit.cloudera.org:8080/#/c/24863/2/src/kudu/rebalance/rebalance_algo-test.cc
File src/kudu/rebalance/rebalance_algo-test.cc:
http://gerrit.cloudera.org:8080/#/c/24863/2/src/kudu/rebalance/rebalance_algo-test.cc@221
PS2, Line 221: /*prefer_follower_moves=*/true
Don't see any unit test with 'prefer_follower_moves=false'. Any reason for that?
http://gerrit.cloudera.org:8080/#/c/24863/2/src/kudu/rebalance/rebalance_algo.h
File src/kudu/rebalance/rebalance_algo.h:
http://gerrit.cloudera.org:8080/#/c/24863/2/src/kudu/rebalance/rebalance_algo.h@a198
PS2, Line 198:
question - Why not keep this, to prevent implicit conversion from braced initializer lists - {arg1, arg2} ?
LocationBalancingAlgo has the keyword.
http://gerrit.cloudera.org:8080/#/c/24863/2/src/kudu/rebalance/rebalance_algo.h@198
PS2, Line 198: TwoDimensionalGreedyAlgo(EqualSkewOption opt,
: bool prefer_follower_moves);
nit: Maybe add a comment above providing guidance on impact of both arguments on the algorithm, now that there are no default values.
--
To view, visit http://gerrit.cloudera.org:8080/24863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Gerrit-Change-Number: 24863
Gerrit-PatchSet: 2
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 22 Sep 2026 07:30:08 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3761 drop default for prefer follower moves
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24863 )
Change subject: KUDU-3761 drop default for prefer_follower_moves
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2997/
--
To view, visit http://gerrit.cloudera.org:8080/24863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Gerrit-Change-Number: 24863
Gerrit-PatchSet: 2
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 21 Sep 2026 07:58:08 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3761 drop default for prefer follower moves
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24863 )
Change subject: KUDU-3761 drop default for prefer_follower_moves
......................................................................
Patch Set 3:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/3012/
--
To view, visit http://gerrit.cloudera.org:8080/24863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Gerrit-Change-Number: 24863
Gerrit-PatchSet: 3
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 22 Sep 2026 12:13:59 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3761 drop default for prefer follower moves
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24863 )
Change subject: KUDU-3761 drop default for prefer_follower_moves
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Gerrit-Change-Number: 24863
Gerrit-PatchSet: 4
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Thu, 24 Sep 2026 11:48:05 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3761 drop default for prefer follower moves
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has removed a vote on this change.
Change subject: KUDU-3761 drop default for prefer_follower_moves
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/24863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Gerrit-Change-Number: 24863
Gerrit-PatchSet: 4
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-3761 drop default for prefer follower moves
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24863 )
Change subject: KUDU-3761 drop default for prefer_follower_moves
......................................................................
Patch Set 3: Code-Review+2
LGTM!
Look into latest build (3012) abort.
Maybe trigger a fresh build with rebase.
--
To view, visit http://gerrit.cloudera.org:8080/24863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Gerrit-Change-Number: 24863
Gerrit-PatchSet: 3
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Sep 2026 11:52:05 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3761 drop default for prefer follower moves
Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Ashwani Raina, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24863
to look at the new patch set (#3).
Change subject: KUDU-3761 drop default for prefer_follower_moves
......................................................................
KUDU-3761 drop default for prefer_follower_moves
LocationBalancingAlgo requires callers to pass
'prefer_follower_moves' explicitly. TwoDimensionalGreedyAlgo
still defaulted it to true, so callers could quietly opt into
follower-preferring behavior by leaving the arg off.
Drop that default. The trailing EqualSkewOption default goes
with it (defaults must be contiguous at the end); update the
zero/one-arg call sites in rebalance_algo-test.cc to pass both
args.
Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
---
M src/kudu/rebalance/rebalance_algo-test.cc
M src/kudu/rebalance/rebalance_algo.h
2 files changed, 37 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/24863/3
--
To view, visit http://gerrit.cloudera.org:8080/24863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Gerrit-Change-Number: 24863
Gerrit-PatchSet: 3
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-3761 drop default for prefer follower moves
Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24863 )
Change subject: KUDU-3761 drop default for prefer_follower_moves
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/24863/2/src/kudu/rebalance/rebalance_algo-test.cc
File src/kudu/rebalance/rebalance_algo-test.cc:
http://gerrit.cloudera.org:8080/#/c/24863/2/src/kudu/rebalance/rebalance_algo-test.cc@221
PS2, Line 221: /*prefer_follower_moves=*/true
> Don't see any unit test with 'prefer_follower_moves=false'. Any reason for
There is a false case, just not through this helper: PreferFollowerMovesByTableAndTag covers false for TwoDimensionalGreedyAlgo, LocationBalancingPrefersFollowerSource covers both values for the location algorithm, and RebalancePreferFollowerTest in rebalancer_tool-test.cc is parameterized over both.
For this helper specifically I don't think a false variant would add much: ClusterConfigToClusterInfo doesn't populate ts_with_followers_by_table_and_tag (only BuildClusterInfo does), so with prefer_follower_moves=true no source ever qualifies as hosting a follower and we always end up on the leader fallback, which picks the same move as the false branch. These configs use PICK_FIRST, so there's no shuffling either and both values are deterministic and identical here. The behavioral difference only shows up once the follower map is filled in, which is what PreferFollowerMovesByTableAndTag does.
http://gerrit.cloudera.org:8080/#/c/24863/2/src/kudu/rebalance/rebalance_algo.h
File src/kudu/rebalance/rebalance_algo.h:
http://gerrit.cloudera.org:8080/#/c/24863/2/src/kudu/rebalance/rebalance_algo.h@a198
PS2, Line 198:
> question - Why not keep this, to prevent implicit conversion from braced in
Good point, I have restored it.
http://gerrit.cloudera.org:8080/#/c/24863/2/src/kudu/rebalance/rebalance_algo.h@198
PS2, Line 198: // 'opt' decides how ties are broken when several tables or servers are
: // equally skewed: PICK_FIRST is deterministic, PICK_
> nit: Maybe add a comment above providing guidance on impact of both argumen
Done
--
To view, visit http://gerrit.cloudera.org:8080/24863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Gerrit-Change-Number: 24863
Gerrit-PatchSet: 3
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 22 Sep 2026 12:14:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3761 drop default for prefer follower moves
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24863 )
Change subject: KUDU-3761 drop default for prefer_follower_moves
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2979/
--
To view, visit http://gerrit.cloudera.org:8080/24863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Gerrit-Change-Number: 24863
Gerrit-PatchSet: 1
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Sep 2026 12:46:53 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3761 drop default for prefer follower moves
Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24863 )
Change subject: KUDU-3761 drop default for prefer_follower_moves
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24863/3/src/kudu/rebalance/rebalance_algo.h
File src/kudu/rebalance/rebalance_algo.h:
http://gerrit.cloudera.org:8080/#/c/24863/3/src/kudu/rebalance/rebalance_algo.h@201
PS3, Line 201: the equally skewed candidates
> question: Is 'prefer_follower_moves' effective only when there is a tie bet
Only when several tables are tied at the maximum skew. Among those tied candidates the algorithm picks one whose source hosts a non-leader replica of that table, and falls back to a leader source when none qualifies. With a single most-skewed table there's no alternative to prefer over, so the flag doesn't change which move is emitted.
--
To view, visit http://gerrit.cloudera.org:8080/24863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Gerrit-Change-Number: 24863
Gerrit-PatchSet: 3
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Sep 2026 08:33:31 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3761 drop default for prefer follower moves
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24863 )
Change subject: KUDU-3761 drop default for prefer_follower_moves
......................................................................
Patch Set 4:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/3033/
--
To view, visit http://gerrit.cloudera.org:8080/24863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Gerrit-Change-Number: 24863
Gerrit-PatchSet: 4
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Sep 2026 14:27:13 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3761 drop default for prefer follower moves
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24863 )
Change subject: KUDU-3761 drop default for prefer_follower_moves
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Gerrit-Change-Number: 24863
Gerrit-PatchSet: 2
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 21 Sep 2026 13:50:55 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3761 drop default for prefer follower moves
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24863 )
Change subject: KUDU-3761 drop default for prefer_follower_moves
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/2979/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/24863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Gerrit-Change-Number: 24863
Gerrit-PatchSet: 1
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Sep 2026 12:51:06 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3761 drop default for prefer follower moves
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24863 )
Change subject: KUDU-3761 drop default for prefer_follower_moves
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Thank you for addressing the comments.
I just have one question regarding the comment text.
Rest looks good to me.
http://gerrit.cloudera.org:8080/#/c/24863/2/src/kudu/rebalance/rebalance_algo-test.cc
File src/kudu/rebalance/rebalance_algo-test.cc:
http://gerrit.cloudera.org:8080/#/c/24863/2/src/kudu/rebalance/rebalance_algo-test.cc@221
PS2, Line 221: /*prefer_follower_moves=*/true
> There is a false case, just not through this helper: PreferFollowerMovesByT
Makes sense.
Thanks for the explanation.
http://gerrit.cloudera.org:8080/#/c/24863/3/src/kudu/rebalance/rebalance_algo.h
File src/kudu/rebalance/rebalance_algo.h:
http://gerrit.cloudera.org:8080/#/c/24863/3/src/kudu/rebalance/rebalance_algo.h@201
PS3, Line 201: the equally skewed candidates
question: Is 'prefer_follower_moves' effective only when there is a tie between equally skewed candidates? Or 'prefer_follower_moves' works independent of whether there there are equal skewed candidates or not?
--
To view, visit http://gerrit.cloudera.org:8080/24863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Gerrit-Change-Number: 24863
Gerrit-PatchSet: 3
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Sep 2026 05:26:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3761 drop default for prefer follower moves
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24863 )
Change subject: KUDU-3761 drop default for prefer_follower_moves
......................................................................
Patch Set 4: Verified+1 Code-Review+2
unrelated test failures:
debug: partition_pruner-test.0, master_replication-itest.0
release: raft_consensus-itest.0
tsan: tls_socket-test.0
--
To view, visit http://gerrit.cloudera.org:8080/24863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Gerrit-Change-Number: 24863
Gerrit-PatchSet: 4
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Thu, 24 Sep 2026 12:11:08 +0000
Gerrit-HasComments: No