You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/11 15:16:11 UTC
[GitHub] [incubator-superset] geido opened a new pull request #12013: refactor: Existing Antd Collapse to enhanced
geido opened a new pull request #12013:
URL: https://github.com/apache/incubator-superset/pull/12013
### SUMMARY
This enhanced the Antd Collapse with Emotion styled components and replaces the existing instances of Antd Collapse with the enhanced one
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
<img width="349" alt="before-1" src="https://user-images.githubusercontent.com/60598000/101920429-76f7f800-3bd4-11eb-806e-eceb131be4e1.png">
<img width="1631" alt="before-2" src="https://user-images.githubusercontent.com/60598000/101920433-78292500-3bd4-11eb-85a8-a6518b04ebbc.png">
<img width="1087" alt="before-3" src="https://user-images.githubusercontent.com/60598000/101920438-78292500-3bd4-11eb-8a26-389749c895b5.png">
AFTER:
<img width="315" alt="after-1" src="https://user-images.githubusercontent.com/60598000/101920455-7f503300-3bd4-11eb-9f95-cd66ea9b268e.png">
<img width="1660" alt="after-2" src="https://user-images.githubusercontent.com/60598000/101920458-7fe8c980-3bd4-11eb-8fad-5027096b121e.png">
<img width="1097" alt="after-3" src="https://user-images.githubusercontent.com/60598000/101920459-80816000-3bd4-11eb-89b3-a27769892ad3.png">
### TEST PLAN
1. Log into Superset
2. Open the different collapsible sections in the welcome page
3. Go to Dashboards and select an existing dashboard
4. Check for the filter icon on top of each chart and show the filters
5. Expand a chart
6. Look for the "Data" collapse bottom right and open it
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #12013: refactor: Existing Antd Collapse to enhanced
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12013:
URL: https://github.com/apache/incubator-superset/pull/12013#issuecomment-743276878
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12013?src=pr&el=h1) Report
> Merging [#12013](https://codecov.io/gh/apache/incubator-superset/pull/12013?src=pr&el=desc) (434f511) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `13.45%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12013?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12013 +/- ##
===========================================
- Coverage 67.88% 54.42% -13.46%
===========================================
Files 948 433 -515
Lines 46177 15255 -30922
Branches 4405 3896 -509
===========================================
- Hits 31348 8303 -23045
+ Misses 14722 6952 -7770
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.42% <80.00%> (+<0.01%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12013?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...dashboard/components/FiltersBadge/DetailsPanel.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwudHN4) | `40.54% <ø> (-9.46%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `55.73% <ø> (-5.70%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `76.19% <ø> (-1.09%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `2.94% <ø> (-76.66%)` | :arrow_down: |
| [...perset-frontend/src/common/components/Collapse.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0NvbGxhcHNlLnRzeA==) | `80.00% <80.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| ... and [803 more](https://codecov.io/gh/apache/incubator-superset/pull/12013/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12013?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12013?src=pr&el=footer). Last update [916f7e9...434f511](https://codecov.io/gh/apache/incubator-superset/pull/12013?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] geido commented on pull request #12013: refactor: Existing Antd Collapse to enhanced
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #12013:
URL: https://github.com/apache/incubator-superset/pull/12013#issuecomment-743262908
@junlincc @rusackas
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #12013: refactor: Existing Antd Collapse to enhanced
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #12013:
URL: https://github.com/apache/incubator-superset/pull/12013
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org