You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/08 07:53:07 UTC

[GitHub] [cloudstack] utchoang opened a new pull request #4766: UI: Submit the form when press enter

utchoang opened a new pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766


   ### Description
   Related #4762 
   This PR for fixes submit the form when press enter
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-802674173


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-41)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-808042503


   @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-886501450


   @utchoang Facing the issue mentioned in https://github.com/apache/cloudstack/pull/4766#issuecomment-815467043 again, perhaps something changed in https://github.com/apache/cloudstack/pull/4766/commits/a6c9086f98fd2f3f147204cacb689f146e54e0bd#diff-dc23cc72876b181f8c378a3aae62dd04c7e3dcddea70113f45ac8acd741ceca7 broke it ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-808011584


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-808105032


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-808014281


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-76)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-882955609


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-384)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-813980078


   @utchoang can you fix the conflict? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press enter

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-792556122


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (JID-3855)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-814890920


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-886462303


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-424)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#discussion_r676378245



##########
File path: ui/src/utils/directives.js
##########
@@ -0,0 +1,36 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import Vue from 'vue'
+
+const ENTER_KEY_CODE = 13
+// let lastFocusElm = null
+
+Vue.directive('ctrlEnter', {
+  bind: (el, binding, vnode) => {
+    el.addEventListener('keyup', (e) => {
+      if (!e.ctrlKey || e.keyCode !== ENTER_KEY_CODE) {
+        return
+      }
+

Review comment:
       Wil need a e.preventDefault() here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-821085799


   @davidjumani can you review? cc @Pearl1594 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-805563248


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-60)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-882478519


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-814893624


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-90)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani edited a comment on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-815475211


   @utchoang The checkbox gets selected while pressing crtl+enter when focused. You can also try it on any form on which a switch is focused
   ![ctletr](https://user-images.githubusercontent.com/8244774/113976310-92130580-985e-11eb-8fe8-b5543e6f0880.gif)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-886431729


   @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-882953782


   @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-882174116


   @utchoang can you please fix the conflicts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#discussion_r676350681



##########
File path: ui/src/views/network/InternalLBAssignVmForm.vue
##########
@@ -80,7 +80,7 @@
       <a-button @click="closeModal">
         {{ $t('label.cancel') }}
       </a-button>
-      <a-button type="primary" @click="handleSubmit">
+      <a-button type="primary" ref="submit" @click="handleSubmit">

Review comment:
       Add a check of fetchLoading somewhere in handleSubmit ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-882481100


   UI build: :heavy_multiplication_x:
    (SL-JID-383)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-883979758


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-802652520


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-40)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press enter

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-802607083


   @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#discussion_r675322567



##########
File path: ui/src/views/compute/EditVM.vue
##########
@@ -73,7 +73,7 @@
 
       <div :span="24" class="action-button">
         <a-button :loading="loading" @click="onCloseAction">{{ this.$t('label.cancel') }}</a-button>
-        <a-button :loading="loading" type="primary" @click="handleSubmit">{{ this.$t('label.ok') }}</a-button>
+        <a-button :loading="loading" ref="submit" type="primary" @click="handleSubmit">{{ this.$t('label.ok') }}</a-button>

Review comment:
       v-ctrl-enter="handleSubmit" in this form ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-805559942


   @rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-820184068


   @utchoang can you fix the conflict
   @davidjumani can you review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] andrijapanicsb commented on pull request #4766: UI: Submit the form when press enter

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-801768499


   Industry practice, from what I've seen is to use CTRL + ENTER to submit a form (i.e. in gmail to send email, in Jira to send comment, in Outlook to send email, etc)
   
   simple ENTER sounds a bit "dangerous"


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-808107443


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-78)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#discussion_r602066135



##########
File path: ui/src/views/project/AddAccountOrUserToProject.vue
##########
@@ -17,7 +17,10 @@
 <template>
   <div>
     <a-tabs class="form-layout">
-      <a-tab-pane key="1" :tab="$t('label.action.project.add.account')">
+      <a-tab-pane
+        key="1"
+        :tab="$t('label.action.project.add.account')"
+        v-ctrl-enter="addAccountToProject">

Review comment:
       A check for this.loading = true to prevent multiple submits ?

##########
File path: ui/src/views/project/AddAccountOrUserToProject.vue
##########
@@ -83,7 +86,11 @@
           </div>
         </a-form>
       </a-tab-pane>
-      <a-tab-pane key="2" :tab="$t('label.action.project.add.user')" v-if="apiParams.addUserToProject">
+      <a-tab-pane
+        key="2"
+        :tab="$t('label.action.project.add.user')"
+        v-if="apiParams.addUserToProject"
+        v-ctrl-enter="addUserToProject">

Review comment:
       Ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-802608791


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-39)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-882953609


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-814075413


   @utchoang can you fix the conflicts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez merged pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-882478519


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-886532027


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-886434639


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-423)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-885974190


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-882478519


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-802670677


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-815467043


   This causes an issue when the item focused is a switch, and pressing control enter toggles the value as well as submits the form.
   Try stopping a VM while forced is focused via ctrl-enter and the switch toggles and the VM is force stopped
   Could be other issues, looking into it
   So far works well with non switches / text / select as the focused element


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-815474382


   @davidjumani I have checked to stop a VM even if focus or lost focus from the switch element, then pressing Ctrl + Enter still performs submit normally. Don't know how your problem is?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-811698956


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-82)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-885974257


   @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-885974936


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-414)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-808044626


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-77)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-816388175


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#discussion_r675470208



##########
File path: ui/src/views/storage/AttachVolume.vue
##########
@@ -38,7 +38,7 @@
     </a-form>
     <div class="actions">
       <a-button @click="closeAction">{{ $t('label.cancel') }}</a-button>
-      <a-button type="primary" @click="handleSubmit">{{ $t('label.ok') }}</a-button>
+      <a-button type="primary" ref="submit" @click="handleSubmit">{{ $t('label.ok') }}</a-button>

Review comment:
       v-ctrl-enter="handleSubmit" in this form ?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-882953609


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-866914902


   @nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-882478955


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-886431420


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #4766: UI: Submit the form when press enter

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-801743834


   @rhtyd Yes, currently for textarea, selectbox focus the press enter will not submit the form


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #4766: UI: Submit the form when press enter

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-792552719


   @blueorangutan ui


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-816388083


   @davidjumani Tested in firefox browser
   ![bandicam 2021-04-09 11-11-33-400](https://user-images.githubusercontent.com/13766648/114127411-90ac1080-9924-11eb-8ff2-bf447471a37c.gif)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-886495850


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-815581383


   @utchoang Can you try it in firefox ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-811695193


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#discussion_r676304179



##########
File path: ui/src/views/infra/zone/ZoneWizardPhysicalNetworkSetupStep.vue
##########
@@ -129,24 +130,26 @@
       :visible="showError"
       :title="`${$t('label.error')}!`"
       :maskClosable="false"
-      :okText="$t('label.ok')"
-      :cancelText="$t('label.cancel')"
-      @ok="() => { showError = false }"
+      :closable="true"
+      :footer="null"
       @cancel="() => { showError = false }"
+      v-ctrl-enter="showError = false"
       centered
     >
       <span>{{ $t('message.required.traffic.type') }}</span>
+      <div :span="24" class="action-button">
+        <a-button @click="showError = false">{{ $t('label.cancel') }}</a-button>
+        <a-button type="primary" ref="submit" @click="showError = false">{{ $t('label.ok') }}</a-button>
+      </div>
     </a-modal>
     <a-modal
       :title="$t('label.edit.traffic.type')"
       :visible="showEditTraffic"
       :closable="true"
       :maskClosable="false"
-      :okText="$t('label.ok')"
-      :cancelText="$t('label.cancel')"
-      @ok="updateTrafficLabel(trafficInEdit)"
-      @cancel="cancelEditTraffic"
       centered
+      :footer="null"
+      v-ctrl-enter="updateTrafficLabel(trafficInEdit)"

Review comment:
       `TypeError: trafficInEdit is null`. Looks like an error elsewhere in the file, can you fix it ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-802649891


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-814890409


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-815475211


   @utchoang 
   ![ctletr](https://user-images.githubusercontent.com/8244774/113976310-92130580-985e-11eb-8fe8-b5543e6f0880.gif)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-802650102


   @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-883892306


   @utchoang Can you fix the conflicts ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-886535183


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-426)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-866927010


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-278)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#discussion_r676294922



##########
File path: ui/src/views/network/InternalLBAssignVmForm.vue
##########
@@ -80,7 +80,7 @@
       <a-button @click="closeModal">
         {{ $t('label.cancel') }}
       </a-button>
-      <a-button type="primary" @click="handleSubmit">
+      <a-button type="primary" ref="submit"  @click="handleSubmit">

Review comment:
       ```suggestion
         <a-button type="primary" ref="submit" @click="handleSubmit">
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-882478955






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-882478955






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-885525442


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#discussion_r675483299



##########
File path: ui/src/views/compute/MigrateWizard.vue
##########
@@ -85,7 +85,7 @@
     </a-pagination>
 
     <div style="margin-top: 20px; display: flex; justify-content:flex-end;">
-      <a-button type="primary" :disabled="!selectedHost.id" @click="submitForm">
+      <a-button type="primary" ref="submit" :disabled="!selectedHost.id" @click="submitForm">

Review comment:
       v-ctrl-enter="submitForm" here  ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-895102015


   @utchoang I'm getting these errors at times (now while trying to add a firewall rule) by pressing control-enter. Can you please check
   ![Screenshot from 2021-08-09 15-35-58](https://user-images.githubusercontent.com/8244774/128690606-1490b2b0-3ae1-4df3-b104-6f1d283d5859.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-886459793


   @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-824690946


   Moving to 4.16.0.0 as it's a new feature (agree a useful feature) but changes are codebase wide and can potentially add risks to the minor release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-802608791






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #4766: UI: Submit the form when press enter

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-802606615


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-883979933


   @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#discussion_r676348466



##########
File path: ui/src/views/project/InvitationTokenTemplate.vue
##########
@@ -39,10 +39,10 @@
             :placeholder="apiParams.token.description"
           />
         </a-form-item>
-        <div class="card-footer">
-          <!-- ToDo extract as component -->
+
+        <div :span="24" class="action-button">
           <a-button @click="() => $emit('close-action')">{{ this.$t('label.cancel') }}</a-button>
-          <a-button :loading="loading" type="primary" @click="handleSubmit">{{ this.$t('label.ok') }}</a-button>
+          <a-button :loading="loading" ref="submit"  type="primary" @click="handleSubmit">{{ this.$t('label.ok') }}</a-button>

Review comment:
       ```suggestion
             <a-button :loading="loading" ref="submit" type="primary" @click="handleSubmit">{{ this.$t('label.ok') }}</a-button>
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-808104487


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] andrijapanicsb commented on pull request #4766: UI: Submit the form when press enter

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-801768660


   and GitHub also uses CTRL + ENTER to send THIS COMMENT :) 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-883933721


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press enter

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-792553004


   @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang removed a comment on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-802606615


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-883985291


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-401)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#discussion_r676377787



##########
File path: ui/src/utils/directives.js
##########
@@ -0,0 +1,36 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import Vue from 'vue'
+
+const ENTER_KEY_CODE = 13
+// let lastFocusElm = null
+
+Vue.directive('ctrlEnter', {
+  bind: (el, binding, vnode) => {
+    el.addEventListener('keyup', (e) => {
+      if (!e.ctrlKey || e.keyCode !== ENTER_KEY_CODE) {

Review comment:
       Will need a preventDefault over here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-886503956


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-425)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-809910641


   @utchoang can you fix the conflict against latest 4.15 branch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-883935637


   UI build: :heavy_multiplication_x:
    (SL-JID-400)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-866914496


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-885527469


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-413)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-886459495






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-885525120


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-816389619


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-91)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-886531202


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-816388269


   @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#discussion_r676299161



##########
File path: ui/src/views/network/FirewallRules.vue
##########
@@ -426,38 +442,44 @@ export default {
         this.closeModal()
       })
     },
-    handleAddTag () {
+    handleAddTag (e) {
+      e.preventDefault()
+      if (this.addTagLoading) return
       this.addTagLoading = true
-      api('createTags', {
-        'tags[0].key': this.newTag.key,
-        'tags[0].value': this.newTag.value,
-        resourceIds: this.selectedRule,
-        resourceType: 'FirewallRule'
-      }).then(response => {
-        this.$pollJob({
-          jobId: response.createtagsresponse.jobid,
-          successMessage: this.$t('message.success.add.tag'),
-          successMethod: () => {
-            this.parentToggleLoading()
-            this.openTagsModal(this.selectedRule)
-          },
-          errorMessage: this.$t('message.add.tag.failed'),
-          errorMethod: () => {
-            this.parentToggleLoading()
-            this.closeModal()
-          },
-          loadingMessage: this.$t('message.add.tag.processing'),
-          catchMessage: this.$t('error.fetching.async.job.result'),
-          catchMethod: () => {
-            this.parentFetchData()
-            this.parentToggleLoading()
-            this.closeModal()
-          }
+
+      this.newTagsForm.validateFields((err, values) => {
+        if (err) {
+          this.tagsLoading = false
+          return
+        }
+
+        api('createTags', {
+          'tags[0].key': values.key,
+          'tags[0].value': values.value,
+          resourceIds: this.selectedRule,
+          resourceType: 'FirewallRule'
+        }).then(response => {
+          this.$pollJob({
+            jobId: response.createtagsresponse.jobid,
+            successMessage: this.$t('message.success.add.tag'),
+            successMethod: () => {
+              this.parentToggleLoading()
+              this.openTagsModal(this.selectedRule)
+            },
+            errorMessage: this.$t('message.add.tag.failed'),
+            errorMethod: () => {
+              this.parentToggleLoading()
+              this.closeModal()
+            },
+            loadingMessage: this.$t('message.add.tag.processing'),
+            catchMessage: this.$t('error.fetching.async.job.result'),
+            catchMethod: () => {
+              this.parentFetchData()
+              this.parentToggleLoading()
+              this.closeModal()
+            }
+          })
         })
-      }).catch(error => {
-        this.$notifyError(error)
-      }).finally(() => {
-        this.addTagLoading = false

Review comment:
       This needs to be there, else the form is unusable after submitting




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-814008172


   CLGTM. Will test and review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-822191926


   @Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-815558850


   @davidjumani I think this problem belongs to the browser. Since I run on Chrome it works normally. Do not know which browser you use?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-886495236


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-822191750


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-863971660


   @blueorangutan build ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-805559486


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-808012085


   @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4766: UI: Submit the form when press enter

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-801711787


   Could this break anything? (for example in any input that is textarea of multi-line) cc @shwstppr @Pearl1594 @borisstoyanov @vladimirpetrov @andrijapanicsb 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-808042252


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-882953609


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-822193858


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-102)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-802671218


   @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-811695951


   @rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-883935637






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#discussion_r676351112



##########
File path: ui/src/views/infra/zone/ZoneWizardPhysicalNetworkSetupStep.vue
##########
@@ -467,6 +475,7 @@ export default {
       this.emitPhysicalNetworks()
     },
     updateTrafficLabel (trafficInEdit) {
+      console.log(trafficInEdit)

Review comment:
       ```suggestion
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-883933474


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #4766: UI: Submit the form when press CTRL + ENTER

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#issuecomment-886509059


   @davidjumani 
   
   > @utchoang Facing the issue mentioned in [#4766 (comment)](https://github.com/apache/cloudstack/pull/4766#issuecomment-815467043) again, perhaps something changed in [a6c9086#diff-dc23cc72876b181f8c378a3aae62dd04c7e3dcddea70113f45ac8acd741ceca7](https://github.com/apache/cloudstack/commit/a6c9086f98fd2f3f147204cacb689f146e54e0bd#diff-dc23cc72876b181f8c378a3aae62dd04c7e3dcddea70113f45ac8acd741ceca7) broke it ?
   
   sorry I forgot this on Firefox, I'll fix it now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org