You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "cshuo (via GitHub)" <gi...@apache.org> on 2026/03/02 03:42:35 UTC
Re: [PR] fix cdc compare result [hudi]
cshuo commented on code in PR #18262:
URL: https://github.com/apache/hudi/pull/18262#discussion_r2870360579
##########
hudi-common/src/main/java/org/apache/hudi/common/table/cdc/HoodieCDCFileSplit.java:
##########
@@ -126,8 +126,7 @@ public Option<FileSlice> getAfterFileSlice() {
@Override
public int compareTo(HoodieCDCFileSplit o) {
int cmpResult = this.instant.compareTo(o.instant);
- if (cmpResult == 0 && this.cdcInferCase == HoodieCDCInferenceCase.LOG_FILE
- && this.beforeFileSlice.isPresent() && o.getBeforeFileSlice().isPresent()) {
+ if (cmpResult == 0 && this.cdcInferCase == HoodieCDCInferenceCase.LOG_FILE) {
Review Comment:
Why removing the check for Option, since the following code still does `this.beforeFileSlice.get()` and `o.getBeforeFileSlice().get()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org