You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/07 03:27:11 UTC

[GitHub] [flink] zjuwangg commented on a change in pull request #10471: [FLINK-15114][SQL-CLIENT]Add execute result info for alter/create/drop database in sql-client

zjuwangg commented on a change in pull request #10471: [FLINK-15114][SQL-CLIENT]Add execute result info for alter/create/drop database in sql-client
URL: https://github.com/apache/flink/pull/10471#discussion_r355096582
 
 

 ##########
 File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
 ##########
 @@ -605,17 +605,32 @@ private void callSource(SqlCommandCall cmdCall) {
 
 	private void callCreateDatabase(SqlCommandCall cmdCall) {
 		final String createDatabaseStmt = cmdCall.operands[0];
-		executor.executeUpdate(sessionId, createDatabaseStmt);
+		try {
+			executor.executeUpdate(sessionId, createDatabaseStmt);
+			printInfo(CliStrings.MESSAGE_DATABASE_CREATED);
+		} catch (SqlExecutionException e) {
 
 Review comment:
   We don't need this method for `printInfo ` has called `terminal.flush`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services