You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/10/07 06:11:00 UTC

[jira] [Work logged] (HIVE-24082) Expose information whether AcidUtils.ParsedDelta contains statementId

     [ https://issues.apache.org/jira/browse/HIVE-24082?focusedWorklogId=496321&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-496321 ]

ASF GitHub Bot logged work on HIVE-24082:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Oct/20 06:10
            Start Date: 07/Oct/20 06:10
    Worklog Time Spent: 10m 
      Work Description: harmandeeps commented on a change in pull request #1438:
URL: https://github.com/apache/hive/pull/1438#discussion_r500759183



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -1031,8 +1031,12 @@ public Path getPath() {
       return path;
     }
 
+    public boolean hasStatementId() {

Review comment:
       yeah, we may need this information outside the Hive to figure out whether statementId is present for the delta.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 496321)
    Time Spent: 2h 20m  (was: 2h 10m)

> Expose information whether AcidUtils.ParsedDelta contains statementId
> ---------------------------------------------------------------------
>
>                 Key: HIVE-24082
>                 URL: https://issues.apache.org/jira/browse/HIVE-24082
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Piotr Findeisen
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> In [Presto|https://prestosql.io] we support reading ORC ACID tables by leveraging AcidUtils rather than duplicate the file name parsing logic in our code.
> To do this fully correctly, we need information whether {{org.apache.hadoop.hive.ql.io.AcidUtils.ParsedDelta}} contains {{statementId}} information or not. 
> Currently, a getter of that property does not allow us to access this information.
> [https://github.com/apache/hive/blob/468907eab36f78df3e14a24005153c9a23d62555/ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java#L804-L806]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)