You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Laszlo Kishalmi <la...@gmail.com> on 2020/01/07 17:07:22 UTC
Remove (experimental) from FlatLaf Dark
Dear all, Karl,
Feature freeze is closing for 11.3 (next week). Thanks to Karl and other
active community members, FlatLaf Dark has progressed a lot and it is a
completely usable modern dark Laf for NetBeans. It can make the Darcula
plugin (AFAIK, the most downloaded NetBeans plugin from the plugin
portal) obsolete. I see only 4 fixable issues:
1. Form designer: https://github.com/apache/netbeans/pull/1846
2. The versioning annotations and diff colors needs some adjustments to
the dark theme.
3. The border color of the search bar does not follow the LaF palette. I
guess that's just one line in a property file change.
4. Unbounded progress bar height is really small. (I do not know that it
is by design, but for me it's visually confusing)
Does anybody see anything else, before we could remove the
(experimental) adjective from this LaF?
BTW FlatLaf Light looks good as well it just missing some coloring
review and perhaps a fitting Editor Color theme.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Remove (experimental) from FlatLaf Dark
Posted by Tomáš Procházka <ka...@razdva.cz>.
Found another minor issue with property color in auto-complete windows:
https://issues.apache.org/jira/browse/NETBEANS-3706
Anyway FlatLaf Dark is great, I was coding with it whole day and did not
found any major issue making me to go back to Darcula LaF plugin.
With regards.
Tomáš Procházka
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Remove (experimental) from FlatLaf Dark
Posted by Tomáš Procházka <ka...@razdva.cz>.
Thank you.
I tried it and highlighted code is readable now.
There seems to be another problem with coloring of ignored files.
Filed issue https://issues.apache.org/jira/browse/NETBEANS-3701
On 2020/01/16 03:08:25, Laszlo Kishalmi <l....@gmail.com> wrote: > Check
this one: https://github.com/apache/netbeans/pull/1875> > > On 1/14/20
11:44 PM, Tomáš Procházka wrote:> > > Hi,> > > when FlatLaf Dark is used
and code coverage is displayed, then> > > background color of both
covered and uncovered lines makes code hard to> > > read.> > >> > >
Similar problem was also reported for Darcula plugin:> > >
https://github.com/Revivius/nb-darcula/issues/131> > >> > > Thanks to
all for your work on making NetBeans looking and working great.> > >> >
> With regards,> > > Tomáš Procházka> > >> > >> > >
---------------------------------------------------------------------> >
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org> > > For
additional commands, e-mail: dev-help@netbeans.apache.org> > >> > > For
further information about the NetBeans mailing lists, visit:> > >
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists> > >>
> >> > >> > >
---------------------------------------------------------------------> >
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org> > For
additional commands, e-mail: dev-help@netbeans.apache.org> > > For
further information about the NetBeans mailing lists, visit:> >
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists> > > > >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Remove (experimental) from FlatLaf Dark
Posted by Laszlo Kishalmi <la...@gmail.com>.
Check this one: https://github.com/apache/netbeans/pull/1875
On 1/14/20 11:44 PM, Tomáš Procházka wrote:
> Hi,
> when FlatLaf Dark is used and code coverage is displayed, then
> background color of both covered and uncovered lines makes code hard to
> read.
>
> Similar problem was also reported for Darcula plugin:
> https://github.com/Revivius/nb-darcula/issues/131
>
> Thanks to all for your work on making NetBeans looking and working great.
>
> With regards,
> Tomáš Procházka
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Remove (experimental) from FlatLaf Dark
Posted by Laszlo Kishalmi <la...@gmail.com>.
Good catch!
Though it is out of FlatLaf, just checked the code those colors are hard
coded in the coverage support code.
I'm going to create an issue to have those configurable through the
Editor highlights, then we could apply different default colors to them
per Editor Profile.
On 1/14/20 11:44 PM, Tomáš Procházka wrote:
> Hi,
> when FlatLaf Dark is used and code coverage is displayed, then
> background color of both covered and uncovered lines makes code hard to
> read.
>
> Similar problem was also reported for Darcula plugin:
> https://github.com/Revivius/nb-darcula/issues/131
>
> Thanks to all for your work on making NetBeans looking and working great.
>
> With regards,
> Tomáš Procházka
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Remove (experimental) from FlatLaf Dark
Posted by Tomáš Procházka <to...@bizbox.cz>.
Hi,
when FlatLaf Dark is used and code coverage is displayed, then
background color of both covered and uncovered lines makes code hard to
read.
Similar problem was also reported for Darcula plugin:
https://github.com/Revivius/nb-darcula/issues/131
Thanks to all for your work on making NetBeans looking and working great.
With regards,
Tomáš Procházka
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Remove (experimental) from FlatLaf Dark
Posted by Laszlo Kishalmi <la...@gmail.com>.
Yes, first and foremost on the status bar. Some builds are switching
from unbounded to bounded and we have a text a tiny progress bar then a
close icon.
Waiting for the next library drop! Thank you!
On 1/8/20 8:58 AM, Karl Tauber wrote:
> Laszlo,
>
> just curious: is there a special place where you find the small
> progress bar height visually confusing? In the status bar? Or in some
> dialog?
>
> I've noticed that the progress bar height in the status bar is
> sometimes small (without progress text) and sometimes large (with
> progress text). Sometimes it jumps from small to large or vice versa.
> I'll have a look how to pin this to one height...
>
>
> The small height is nowadays standard in modern UIs.
> But I have no problem to make it larger in NB.
>
> In the next FlatLaf release, I'll change the progress color in the
> dark theme from light gray to blue (similar to the light theme). This
> should make the progress bar better recognizable.
>
>
> Karl
>
>
>
> On 07.01.2020 19:31, Karl Tauber wrote:
>> +1
>>
>>
>> I'm already working on 2., 3. and on NETBEANS-3657.
>> PRs are coming soon...
>>
>>
>> You can change the progress bar height in FlatLaf.properties.
>> The default is:
>> ProgressBar.horizontalSize=146,4
>>
>> Try whether this is better:
>> ProgressBar.horizontalSize=146,6
>>
>>
>> I also like to improve the editor/view tabs to address Eirik's
>> comments in PR 1771. And look at the other dark LaFs to find colors
>> that need fixes in FlatLaf.
>>
>>
>> Karl
>>
>>
>> On 07.01.2020 18:07, Laszlo Kishalmi wrote:
>>> Dear all, Karl,
>>>
>>> Feature freeze is closing for 11.3 (next week). Thanks to Karl and
>>> other active community members, FlatLaf Dark has progressed a lot
>>> and it is a completely usable modern dark Laf for NetBeans. It can
>>> make the Darcula plugin (AFAIK, the most downloaded NetBeans plugin
>>> from the plugin portal) obsolete. I see only 4 fixable issues:
>>>
>>> 1. Form designer: https://github.com/apache/netbeans/pull/1846
>>>
>>> 2. The versioning annotations and diff colors needs some adjustments
>>> to the dark theme.
>>>
>>> 3. The border color of the search bar does not follow the LaF
>>> palette. I guess that's just one line in a property file change.
>>>
>>> 4. Unbounded progress bar height is really small. (I do not know
>>> that it is by design, but for me it's visually confusing)
>>>
>>> Does anybody see anything else, before we could remove the
>>> (experimental) adjective from this LaF?
>>>
>>> BTW FlatLaf Light looks good as well it just missing some coloring
>>> review and perhaps a fitting Editor Color theme.
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
>>> For additional commands, e-mail: dev-help@netbeans.apache.org
>>>
>>> For further information about the NetBeans mailing lists, visit:
>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>>
>>>
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
>> For additional commands, e-mail: dev-help@netbeans.apache.org
>>
>> For further information about the NetBeans mailing lists, visit:
>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Remove (experimental) from FlatLaf Dark
Posted by Karl Tauber <ka...@jformdesigner.com>.
Laszlo,
just curious: is there a special place where you find the small progress
bar height visually confusing? In the status bar? Or in some dialog?
I've noticed that the progress bar height in the status bar is sometimes
small (without progress text) and sometimes large (with progress text).
Sometimes it jumps from small to large or vice versa.
I'll have a look how to pin this to one height...
The small height is nowadays standard in modern UIs.
But I have no problem to make it larger in NB.
In the next FlatLaf release, I'll change the progress color in the dark
theme from light gray to blue (similar to the light theme). This should
make the progress bar better recognizable.
Karl
On 07.01.2020 19:31, Karl Tauber wrote:
> +1
>
>
> I'm already working on 2., 3. and on NETBEANS-3657.
> PRs are coming soon...
>
>
> You can change the progress bar height in FlatLaf.properties.
> The default is:
> ProgressBar.horizontalSize=146,4
>
> Try whether this is better:
> ProgressBar.horizontalSize=146,6
>
>
> I also like to improve the editor/view tabs to address Eirik's comments
> in PR 1771. And look at the other dark LaFs to find colors that need
> fixes in FlatLaf.
>
>
> Karl
>
>
> On 07.01.2020 18:07, Laszlo Kishalmi wrote:
>> Dear all, Karl,
>>
>> Feature freeze is closing for 11.3 (next week). Thanks to Karl and
>> other active community members, FlatLaf Dark has progressed a lot and
>> it is a completely usable modern dark Laf for NetBeans. It can make
>> the Darcula plugin (AFAIK, the most downloaded NetBeans plugin from
>> the plugin portal) obsolete. I see only 4 fixable issues:
>>
>> 1. Form designer: https://github.com/apache/netbeans/pull/1846
>>
>> 2. The versioning annotations and diff colors needs some adjustments
>> to the dark theme.
>>
>> 3. The border color of the search bar does not follow the LaF palette.
>> I guess that's just one line in a property file change.
>>
>> 4. Unbounded progress bar height is really small. (I do not know that
>> it is by design, but for me it's visually confusing)
>>
>> Does anybody see anything else, before we could remove the
>> (experimental) adjective from this LaF?
>>
>> BTW FlatLaf Light looks good as well it just missing some coloring
>> review and perhaps a fitting Editor Color theme.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
>> For additional commands, e-mail: dev-help@netbeans.apache.org
>>
>> For further information about the NetBeans mailing lists, visit:
>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Remove (experimental) from FlatLaf Dark
Posted by Laszlo Kishalmi <la...@gmail.com>.
Thanks for your good eyes Eirik!
"Maximize use of native look and feel" is only used for Open File
action. I guess it is more used in platform applications, than in the
IDE itself. I might keep it, however it shall be enabled only when
native LaF is selected.
On 1/8/20 12:55 PM, Eirik Bakke wrote:
> +1
>
> I just tried the latest FlatLAF version, both dark and light, on HiDPI and regular displays on Windows. It certainly looks complete enough to remove the "experimental" mark!
>
> Some possible tweaks for the future (besides my earlier comments about tab button borders):
> * In the Property Sheet, horizontal separator lines are missing on the right-hand side, where property values are painted.
> * The text in JButton components could be moved up 1 pixel, for better vertical centering.
> * The main editor tab row has a slight blue tint on both the dark and light themes. I have a slight preference for keeping background colors for non-selected components in a neutral shade of grey.
> * I wonder if it would be possible to get rid of the "Maximize use of native look and feel" checkbox in the options dialog (corresponds to WinSysPrefs.MAXIMIZE_NATIVE_LAF). As far as I can see grepping the sources, the only thing it controls is whether to use the native file chooser. Are there still cases where this needs to be used?
>
> Thanks for this great contribution to NetBeans!
>
> -- Eirik
>
> -----Original Message-----
> From: Karl Tauber <ka...@jformdesigner.com>
> Sent: Tuesday, January 7, 2020 7:32 PM
> To: dev@netbeans.apache.org
> Subject: Re: Remove (experimental) from FlatLaf Dark
>
> +1
>
>
> I'm already working on 2., 3. and on NETBEANS-3657.
> PRs are coming soon...
>
>
> You can change the progress bar height in FlatLaf.properties.
> The default is:
> ProgressBar.horizontalSize=146,4
>
> Try whether this is better:
> ProgressBar.horizontalSize=146,6
>
>
> I also like to improve the editor/view tabs to address Eirik's comments in PR 1771. And look at the other dark LaFs to find colors that need fixes in FlatLaf.
>
>
> Karl
>
>
> On 07.01.2020 18:07, Laszlo Kishalmi wrote:
>> Dear all, Karl,
>>
>> Feature freeze is closing for 11.3 (next week). Thanks to Karl and
>> other active community members, FlatLaf Dark has progressed a lot and
>> it is a completely usable modern dark Laf for NetBeans. It can make
>> the Darcula plugin (AFAIK, the most downloaded NetBeans plugin from
>> the plugin
>> portal) obsolete. I see only 4 fixable issues:
>>
>> 1. Form designer: https://github.com/apache/netbeans/pull/1846
>>
>> 2. The versioning annotations and diff colors needs some adjustments
>> to the dark theme.
>>
>> 3. The border color of the search bar does not follow the LaF palette.
>> I guess that's just one line in a property file change.
>>
>> 4. Unbounded progress bar height is really small. (I do not know that
>> it is by design, but for me it's visually confusing)
>>
>> Does anybody see anything else, before we could remove the
>> (experimental) adjective from this LaF?
>>
>> BTW FlatLaf Light looks good as well it just missing some coloring
>> review and perhaps a fitting Editor Color theme.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
>> For additional commands, e-mail: dev-help@netbeans.apache.org
>>
>> For further information about the NetBeans mailing lists, visit:
>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>
>>
>>
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Remove (experimental) from FlatLaf Dark
Posted by tygrysekHD <ty...@gmail.com>.
One thing from me.
When you use light FlatLAF
And you set "Tab placement" option to the "Right" value
Then the horizontal separator line between tabs with file names are hard
to see
Siemka ,
Piotr
W dniu 2020-01-08 o 21:55, Eirik Bakke pisze:
> +1
>
> I just tried the latest FlatLAF version, both dark and light, on HiDPI and regular displays on Windows. It certainly looks complete enough to remove the "experimental" mark!
>
> Some possible tweaks for the future (besides my earlier comments about tab button borders):
> * In the Property Sheet, horizontal separator lines are missing on the right-hand side, where property values are painted.
> * The text in JButton components could be moved up 1 pixel, for better vertical centering.
> * The main editor tab row has a slight blue tint on both the dark and light themes. I have a slight preference for keeping background colors for non-selected components in a neutral shade of grey.
> * I wonder if it would be possible to get rid of the "Maximize use of native look and feel" checkbox in the options dialog (corresponds to WinSysPrefs.MAXIMIZE_NATIVE_LAF). As far as I can see grepping the sources, the only thing it controls is whether to use the native file chooser. Are there still cases where this needs to be used?
>
> Thanks for this great contribution to NetBeans!
>
> -- Eirik
>
> -----Original Message-----
> From: Karl Tauber <ka...@jformdesigner.com>
> Sent: Tuesday, January 7, 2020 7:32 PM
> To: dev@netbeans.apache.org
> Subject: Re: Remove (experimental) from FlatLaf Dark
>
> +1
>
>
> I'm already working on 2., 3. and on NETBEANS-3657.
> PRs are coming soon...
>
>
> You can change the progress bar height in FlatLaf.properties.
> The default is:
> ProgressBar.horizontalSize=146,4
>
> Try whether this is better:
> ProgressBar.horizontalSize=146,6
>
>
> I also like to improve the editor/view tabs to address Eirik's comments in PR 1771. And look at the other dark LaFs to find colors that need fixes in FlatLaf.
>
>
> Karl
>
>
> On 07.01.2020 18:07, Laszlo Kishalmi wrote:
>> Dear all, Karl,
>>
>> Feature freeze is closing for 11.3 (next week). Thanks to Karl and
>> other active community members, FlatLaf Dark has progressed a lot and
>> it is a completely usable modern dark Laf for NetBeans. It can make
>> the Darcula plugin (AFAIK, the most downloaded NetBeans plugin from
>> the plugin
>> portal) obsolete. I see only 4 fixable issues:
>>
>> 1. Form designer: https://github.com/apache/netbeans/pull/1846
>>
>> 2. The versioning annotations and diff colors needs some adjustments
>> to the dark theme.
>>
>> 3. The border color of the search bar does not follow the LaF palette.
>> I guess that's just one line in a property file change.
>>
>> 4. Unbounded progress bar height is really small. (I do not know that
>> it is by design, but for me it's visually confusing)
>>
>> Does anybody see anything else, before we could remove the
>> (experimental) adjective from this LaF?
>>
>> BTW FlatLaf Light looks good as well it just missing some coloring
>> review and perhaps a fitting Editor Color theme.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
>> For additional commands, e-mail: dev-help@netbeans.apache.org
>>
>> For further information about the NetBeans mailing lists, visit:
>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>
>>
>>
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
RE: Remove (experimental) from FlatLaf Dark
Posted by Eirik Bakke <eb...@ultorg.com>.
+1
I just tried the latest FlatLAF version, both dark and light, on HiDPI and regular displays on Windows. It certainly looks complete enough to remove the "experimental" mark!
Some possible tweaks for the future (besides my earlier comments about tab button borders):
* In the Property Sheet, horizontal separator lines are missing on the right-hand side, where property values are painted.
* The text in JButton components could be moved up 1 pixel, for better vertical centering.
* The main editor tab row has a slight blue tint on both the dark and light themes. I have a slight preference for keeping background colors for non-selected components in a neutral shade of grey.
* I wonder if it would be possible to get rid of the "Maximize use of native look and feel" checkbox in the options dialog (corresponds to WinSysPrefs.MAXIMIZE_NATIVE_LAF). As far as I can see grepping the sources, the only thing it controls is whether to use the native file chooser. Are there still cases where this needs to be used?
Thanks for this great contribution to NetBeans!
-- Eirik
-----Original Message-----
From: Karl Tauber <ka...@jformdesigner.com>
Sent: Tuesday, January 7, 2020 7:32 PM
To: dev@netbeans.apache.org
Subject: Re: Remove (experimental) from FlatLaf Dark
+1
I'm already working on 2., 3. and on NETBEANS-3657.
PRs are coming soon...
You can change the progress bar height in FlatLaf.properties.
The default is:
ProgressBar.horizontalSize=146,4
Try whether this is better:
ProgressBar.horizontalSize=146,6
I also like to improve the editor/view tabs to address Eirik's comments in PR 1771. And look at the other dark LaFs to find colors that need fixes in FlatLaf.
Karl
On 07.01.2020 18:07, Laszlo Kishalmi wrote:
> Dear all, Karl,
>
> Feature freeze is closing for 11.3 (next week). Thanks to Karl and
> other active community members, FlatLaf Dark has progressed a lot and
> it is a completely usable modern dark Laf for NetBeans. It can make
> the Darcula plugin (AFAIK, the most downloaded NetBeans plugin from
> the plugin
> portal) obsolete. I see only 4 fixable issues:
>
> 1. Form designer: https://github.com/apache/netbeans/pull/1846
>
> 2. The versioning annotations and diff colors needs some adjustments
> to the dark theme.
>
> 3. The border color of the search bar does not follow the LaF palette.
> I guess that's just one line in a property file change.
>
> 4. Unbounded progress bar height is really small. (I do not know that
> it is by design, but for me it's visually confusing)
>
> Does anybody see anything else, before we could remove the
> (experimental) adjective from this LaF?
>
> BTW FlatLaf Light looks good as well it just missing some coloring
> review and perhaps a fitting Editor Color theme.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Remove (experimental) from FlatLaf Dark
Posted by Karl Tauber <ka...@jformdesigner.com>.
+1
I'm already working on 2., 3. and on NETBEANS-3657.
PRs are coming soon...
You can change the progress bar height in FlatLaf.properties.
The default is:
ProgressBar.horizontalSize=146,4
Try whether this is better:
ProgressBar.horizontalSize=146,6
I also like to improve the editor/view tabs to address Eirik's comments
in PR 1771. And look at the other dark LaFs to find colors that need
fixes in FlatLaf.
Karl
On 07.01.2020 18:07, Laszlo Kishalmi wrote:
> Dear all, Karl,
>
> Feature freeze is closing for 11.3 (next week). Thanks to Karl and other
> active community members, FlatLaf Dark has progressed a lot and it is a
> completely usable modern dark Laf for NetBeans. It can make the Darcula
> plugin (AFAIK, the most downloaded NetBeans plugin from the plugin
> portal) obsolete. I see only 4 fixable issues:
>
> 1. Form designer: https://github.com/apache/netbeans/pull/1846
>
> 2. The versioning annotations and diff colors needs some adjustments to
> the dark theme.
>
> 3. The border color of the search bar does not follow the LaF palette. I
> guess that's just one line in a property file change.
>
> 4. Unbounded progress bar height is really small. (I do not know that it
> is by design, but for me it's visually confusing)
>
> Does anybody see anything else, before we could remove the
> (experimental) adjective from this LaF?
>
> BTW FlatLaf Light looks good as well it just missing some coloring
> review and perhaps a fitting Editor Color theme.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists