You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by ac...@apache.org on 2020/04/15 15:31:00 UTC

[incubator-nuttx] 02/05: syslog/rpmsg: remove unused local variable 'g_syslog_rpmsg_channel' which would cause build break.

This is an automated email from the ASF dual-hosted git repository.

acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git

commit 987472d3bb3e911c0774a322fbad763a82b07958
Author: zhongan <zh...@xiaomi.com>
AuthorDate: Thu Apr 9 09:37:04 2020 +0800

    syslog/rpmsg: remove unused local variable 'g_syslog_rpmsg_channel' which would cause build break.
    
    Change-Id: Ie02ef9202ec2a9ecade62c47e4f8956adb96673f
    Signed-off-by: zhongan <zh...@xiaomi.com>
---
 drivers/syslog/syslog_rpmsg.c       | 14 ++------------
 include/nuttx/syslog/syslog_rpmsg.h |  4 ++--
 2 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/drivers/syslog/syslog_rpmsg.c b/drivers/syslog/syslog_rpmsg.c
index 2612059..5a9ea32 100644
--- a/drivers/syslog/syslog_rpmsg.c
+++ b/drivers/syslog/syslog_rpmsg.c
@@ -106,14 +106,6 @@ static int  syslog_rpmsg_ept_cb(FAR struct rpmsg_endpoint *ept,
 
 static struct syslog_rpmsg_s g_syslog_rpmsg;
 
-static const struct syslog_channel_s g_syslog_rpmsg_channel =
-{
-  up_putc,
-  up_putc,
-  syslog_rpmsg_flush,
-  syslog_rpmsg_write,
-};
-
 /****************************************************************************
  * Private Functions
  ****************************************************************************/
@@ -358,8 +350,8 @@ int syslog_rpmsg_putc(int ch)
   return ch;
 }
 
-int syslog_rpmsg_init_early(FAR const char *cpuname, FAR void *buffer,
-                            size_t size)
+void syslog_rpmsg_init_early(FAR const char *cpuname, FAR void *buffer,
+                             size_t size)
 {
   FAR struct syslog_rpmsg_s *priv = &g_syslog_rpmsg;
   char prev, cur;
@@ -403,8 +395,6 @@ out:
       priv->head = priv->tail = 0;
       memset(priv->buffer, 0, size);
     }
-
-  return syslog_channel(&g_syslog_rpmsg_channel);
 }
 
 int syslog_rpmsg_init(void)
diff --git a/include/nuttx/syslog/syslog_rpmsg.h b/include/nuttx/syslog/syslog_rpmsg.h
index 33ec670..ac762f6 100644
--- a/include/nuttx/syslog/syslog_rpmsg.h
+++ b/include/nuttx/syslog/syslog_rpmsg.h
@@ -56,8 +56,8 @@ extern "C"
 #endif
 
 #ifdef CONFIG_SYSLOG_RPMSG
-int syslog_rpmsg_init_early(FAR const char *cpu_name, FAR void *buffer,
-                            size_t size);
+void syslog_rpmsg_init_early(FAR const char *cpu_name, FAR void *buffer,
+                             size_t size);
 int syslog_rpmsg_init(void);
 int syslog_rpmsg_putc(int ch);
 #endif