You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2013/08/01 04:03:34 UTC
svn commit: r1509068 - in /commons/proper/csv/trunk/src:
main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/
test/resources/ferc.gov/
Author: ggregory
Date: Thu Aug 1 02:03:33 2013
New Revision: 1509068
URL: http://svn.apache.org/r1509068
Log:
- Add some real world CSV files.
- Add a record API to get column values using an Enum.
- Throw a better exception when a resource is not found in a class loader for the parser.
- Replace some tabs with spaces.
Added:
commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/FercGovTest.java (with props)
commons/proper/csv/trunk/src/test/resources/ferc.gov/
commons/proper/csv/trunk/src/test/resources/ferc.gov/contract.txt (with props)
commons/proper/csv/trunk/src/test/resources/ferc.gov/readme.txt (with props)
commons/proper/csv/trunk/src/test/resources/ferc.gov/transaction.txt (with props)
Modified:
commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVRecord.java
Modified: commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
URL: http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java?rev=1509068&r1=1509067&r2=1509068&view=diff
==============================================================================
--- commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java (original)
+++ commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java Thu Aug 1 02:03:33 2013
@@ -106,7 +106,7 @@ public class CSVParser implements Iterab
public static CSVParser parseFile(File file, final CSVFormat format) throws IOException {
return new CSVParser(new FileReader(file), format);
}
-
+
/**
* Creates a parser for the given resource.
*
@@ -128,9 +128,38 @@ public class CSVParser implements Iterab
*/
public static CSVParser parseResource(String resource, Charset charset, ClassLoader classLoader,
final CSVFormat format) throws IOException {
- return parseURL(classLoader.getResource(resource), charset, format);
+ URL url = classLoader.getResource(resource);
+ if (url == null) {
+ throw new IllegalArgumentException("Resource cannot be found: " + resource);
+ }
+ return parseURL(url, charset, format);
}
-
+
+ /**
+ * Creates a parser for the given resource.
+ *
+ * <p>
+ * If you do not read all records from the given source, you should call {@link #close()} on the parser.
+ * </p>
+ *
+ * @param resource
+ * a resource path
+ * @param charset
+ * the charset for the resource
+ * @param format
+ * the CSVFormat used for CSV parsing
+ * @return a new parser
+ * @throws IOException
+ * If an I/O error occurs
+ */
+ public static CSVParser parseResource(String resource, Charset charset, final CSVFormat format) throws IOException {
+ URL url = ClassLoader.getSystemResource(resource);
+ if (url == null) {
+ throw new IllegalArgumentException("System resource cannot be found: " + resource);
+ }
+ return parseURL(url, charset, format);
+ }
+
/**
* Creates a parser for the given {@link String} using the default format {@link CSVFormat#DEFAULT}.
*
@@ -201,7 +230,7 @@ public class CSVParser implements Iterab
/**
* CSV parser using the default format {@link CSVFormat#DEFAULT}.
- *
+ *
* <p>
* If you do not read all records from the given {@code reader}, you should call {@link #close()} on the parser,
* unless you close the {@code reader}.
@@ -249,25 +278,26 @@ public class CSVParser implements Iterab
this.record.add(input);
} else {
this.record.add(input.equalsIgnoreCase(nullString) ? null : input);
- }}
+ }
+ }
/**
* Closes resources.
*
- * @throws IOException
- * If an I/O error occurs
+ * @throws IOException
+ * If an I/O error occurs
*/
- public void close() throws IOException {
- if (this.lexer != null) {
- this.lexer.close();
- }
- }
+ public void close() throws IOException {
+ if (this.lexer != null) {
+ this.lexer.close();
+ }
+ }
/**
* Returns the current line number in the input stream.
* <p/>
* ATTENTION: If your CSV input has multi-line values, the returned number does not correspond to the record number.
- *
+ *
* @return current line number
*/
public long getCurrentLineNumber() {
@@ -277,9 +307,8 @@ public class CSVParser implements Iterab
/**
* Returns a copy of the header map that iterates in column order.
* <p>
- * The map keys are column names.
- * The map values are 0-based indices.
- *
+ * The map keys are column names. The map values are 0-based indices.
+ *
* @return a copy of the header map that iterates in column order.
*/
public Map<String, Integer> getHeaderMap() {
@@ -290,7 +319,7 @@ public class CSVParser implements Iterab
* Returns the current record number in the input stream.
* <p/>
* ATTENTION: If your CSV input has multi-line values, the returned number does not correspond to the line number.
- *
+ *
* @return current line number
*/
public long getRecordNumber() {
@@ -302,7 +331,7 @@ public class CSVParser implements Iterab
* entries.
* <p/>
* The returned content starts at the current parse-position in the stream.
- *
+ *
* @return list of {@link CSVRecord} entries, may be empty
* @throws IOException
* on parse error or input read-failure
@@ -350,10 +379,10 @@ public class CSVParser implements Iterab
}
public boolean isClosed() {
- return this.lexer.isClosed();
- }
+ return this.lexer.isClosed();
+ }
- /**
+ /**
* Returns an iterator on the records. IOExceptions occurring during the iteration are wrapped in a
* RuntimeException.
*/
@@ -371,9 +400,9 @@ public class CSVParser implements Iterab
}
public boolean hasNext() {
- if (CSVParser.this.isClosed()) {
- return false;
- }
+ if (CSVParser.this.isClosed()) {
+ return false;
+ }
if (this.current == null) {
this.current = this.getNextRecord();
}
@@ -382,9 +411,9 @@ public class CSVParser implements Iterab
}
public CSVRecord next() {
- if (CSVParser.this.isClosed()) {
- return null;
- }
+ if (CSVParser.this.isClosed()) {
+ return null;
+ }
CSVRecord next = this.current;
this.current = null;
@@ -407,7 +436,7 @@ public class CSVParser implements Iterab
/**
* Parses the next record from the current point in the stream.
- *
+ *
* @return the record as an array of values, or <tt>null</tt> if the end of the stream has been reached
* @throws IOException
* on parse error or input read-failure
@@ -448,7 +477,8 @@ public class CSVParser implements Iterab
if (!this.record.isEmpty()) {
this.recordNumber++;
final String comment = sb == null ? null : sb.toString();
- result = new CSVRecord(this.record.toArray(new String[this.record.size()]), this.headerMap, comment, this.recordNumber);
+ result = new CSVRecord(this.record.toArray(new String[this.record.size()]), this.headerMap, comment,
+ this.recordNumber);
}
return result;
}
Modified: commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVRecord.java
URL: http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVRecord.java?rev=1509068&r1=1509067&r2=1509068&view=diff
==============================================================================
--- commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVRecord.java (original)
+++ commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVRecord.java Thu Aug 1 02:03:33 2013
@@ -54,6 +54,17 @@ public class CSVRecord implements Serial
}
/**
+ * Returns a value by {@link Enum}.
+ *
+ * @param e
+ * an enum
+ * @return the String at the given enum String
+ */
+ public String get(Enum<?> e) {
+ return get(e.toString());
+ }
+
+ /**
* Returns a value by index.
*
* @param i
@@ -171,4 +182,5 @@ public class CSVRecord implements Serial
return Arrays.toString(values);
}
+
}
Added: commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/FercGovTest.java
URL: http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/FercGovTest.java?rev=1509068&view=auto
==============================================================================
--- commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/FercGovTest.java (added)
+++ commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/FercGovTest.java Thu Aug 1 02:03:33 2013
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.csv;
+
+import java.io.IOException;
+import java.nio.charset.Charset;
+import java.util.List;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+/**
+ * Real world examples from http://www.ferc.gov/docs-filing/eqr/soft-tools/sample-csv.asp
+ */
+public class FercGovTest {
+
+ private enum ContractColumnNames {
+ contract_id, seller_company_name, customer_company_name, customer_duns_number, contract_affiliate,
+ FERC_tariff_reference, contract_service_agreement_id, contract_execution_date, contract_commencement_date,
+ contract_termination_date, actual_termination_date, extension_provision_description, class_name, term_name,
+ increment_name, increment_peaking_name, product_type_name, product_name, quantity, units_for_contract, rate,
+ rate_minimum, rate_maximum, rate_description, units_for_rate, point_of_receipt_control_area,
+ point_of_receipt_specific_location, point_of_delivery_control_area, point_of_delivery_specific_location,
+ begin_date, end_date, time_zone;
+ }
+
+ private static final Charset US_ASCII = Charset.forName("US-ASCII");
+
+ @Test
+ public void testContractFile() throws IOException {
+ final CSVParser parser = CSVParser.parseResource("ferc.gov/contract.txt", US_ASCII,
+ CSVFormat.DEFAULT.withHeader());
+ try {
+ final List<CSVRecord> records = parser.getRecords();
+ CSVRecord record = records.get(0);
+ Assert.assertEquals(22, records.size());
+ // first record
+ Assert.assertEquals("C71", record.get(ContractColumnNames.contract_id));
+ Assert.assertEquals("The Electric Company", record.get(ContractColumnNames.seller_company_name));
+ Assert.assertEquals("ES", record.get(ContractColumnNames.time_zone));
+ // last record
+ record = records.get(records.size() - 1);
+ // first record
+ Assert.assertEquals("C78", record.get(ContractColumnNames.contract_id));
+ Assert.assertEquals("The Electric Company", record.get(ContractColumnNames.seller_company_name));
+ Assert.assertEquals("EP", record.get(ContractColumnNames.time_zone));
+ } finally {
+ parser.close();
+ }
+ }
+
+ @Test
+ public void testTransactionFile() throws IOException {
+ final CSVParser parser = CSVParser.parseResource("ferc.gov/transaction.txt", US_ASCII,
+ CSVFormat.DEFAULT.withHeader());
+ try {
+ final List<CSVRecord> records = parser.getRecords();
+ Assert.assertEquals(24, records.size());
+ CSVRecord record = records.get(0);
+ // first record
+ Assert.assertEquals("T1", record.get("transaction_unique_identifier"));
+ Assert.assertEquals("The Electric Company", record.get("seller_company_name"));
+ Assert.assertEquals("880386", record.get("transaction_charge"));
+ // last record
+ record = records.get(records.size() - 1);
+ Assert.assertEquals("T15", record.get("transaction_unique_identifier"));
+ Assert.assertEquals("The Electric Company", record.get("seller_company_name"));
+ Assert.assertEquals("1800", record.get("transaction_charge"));
+ } finally {
+ parser.close();
+ }
+ }
+}
Propchange: commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/FercGovTest.java
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/FercGovTest.java
------------------------------------------------------------------------------
svn:keywords = Id
Added: commons/proper/csv/trunk/src/test/resources/ferc.gov/contract.txt
URL: http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/test/resources/ferc.gov/contract.txt?rev=1509068&view=auto
==============================================================================
--- commons/proper/csv/trunk/src/test/resources/ferc.gov/contract.txt (added)
+++ commons/proper/csv/trunk/src/test/resources/ferc.gov/contract.txt Thu Aug 1 02:03:33 2013
@@ -0,0 +1,23 @@
+contract_id,seller_company_name,customer_company_name,customer_duns_number,contract_affiliate,FERC_tariff_reference,contract_service_agreement_id,contract_execution_date,contract_commencement_date,contract_termination_date,actual_termination_date,extension_provision_description,class_name,term_name,increment_name,increment_peaking_name,product_type_name,product_name,quantity,units_for_contract,rate,rate_minimum,rate_maximum,rate_description,units_for_rate,point_of_receipt_control_area,point_of_receipt_specific_location,point_of_delivery_control_area,point_of_delivery_specific_location,begin_date,end_date,time_zone
+C71,The Electric Company,The Power Company,456543333,N,FERC Electric Tariff Original Volume No. 10,2,2/15/2001,2/15/2001,,,Evergreen,N/A,N/A,N/A,N/A,MB,ENERGY,0,, , , ,Market Based,,,,,,,,ES
+C72,The Electric Company,Utility A,38495837,n,FERC Electric Tariff Original Volume No. 10,15,7/25/2001,8/1/2001,,,Evergreen,N/A,N/A,N/A,N/A,MB,ENERGY,0,, , , ,Market Based,,,,,,,,ES
+C73,The Electric Company,Utility B,493758794,N,FERC Electric Tariff Original Volume No. 10,7,6/8/2001,7/6/2001,,,Evergreen,N/A,N/A,N/A,N/A,MB,ENERGY,0,, , , ,Market Based,,,, , ,,,ep
+C74,The Electric Company,Utility C,594739573,n,FERC Electric Tariff Original Volume No. 10,25,6/8/2001,7/6/2001,,,Evergreen,N/A,N/A,N/A,N/A,MB,ENERGY,0,, , , ,Market Based,,,, , ,,,ep
+C75,The Electric Company,The Power Company,456543333,N,FERC Electric Tariff Third Revised Volume No. 7,94,2/13/2001,7/1/2001,12/31/2006,,None,F,LT,M,P,T,ENERGY,2000,KWh,.1475, , ,Max amount of capacity and energy to be transmitted. Bill based on monthly max delivery to City.,$/KWh,PJM,Point A,PJM,Point B,,,ep
+C75,The Electric Company,The Power Company,456543333,N,FERC Electric Tariff Third Revised Volume No. 7,94,2/13/2001,7/1/2001,12/31/2006,,None,F,LT,M,P,T,point-to-point agreement,2000,KW,0.01, , ,,$/kw-mo,PJM,Point A,PJM,Point B,,,ep
+C75,The Electric Company,The Power Company,456543333,N,FERC Electric Tariff Third Revised Volume No. 7,94,2/13/2001,7/1/2001,12/31/2006,,None,F,LT,M,P,T,network,2000,KW,0.2, , ,,$/kw-mo,PJM,Point A,PJM,Point B,,,ep
+C75,The Electric Company,The Power Company,456543333,N,FERC Electric Tariff Third Revised Volume No. 7,94,2/13/2001,7/1/2001,12/31/2006,,None,F,LT,M,P,T,BLACK START SERVICE,2000,KW,0.22, , ,,$/kw-mo,PJM,Point A,PJM,Point B,,,ep
+C75,The Electric Company,The Power Company,456543333,N,FERC Electric Tariff Third Revised Volume No. 7,94,2/13/2001,7/1/2001,12/31/2006,,None,F,LT,M,P,T,CAPACITY,2000,KW,0.04, , ,,$/kw-mo,PJM,Point A,PJM,Point B,,,ep
+C75,The Electric Company,The Power Company,456543333,N,FERC Electric Tariff Third Revised Volume No. 7,94,2/13/2001,7/1/2001,12/31/2006,,None,F,LT,M,P,T,regulation & frequency response,2000,KW,0.1, , ,,$/kw-mo,PJM,Point A,PJM,Point B,,,ep
+C75,The Electric Company,The Power Company,456543333,N,FERC Electric Tariff Third Revised Volume No. 7,94,2/13/2001,7/1/2001,12/31/2006,,None,F,LT,M,P,T,real power transmission loss,2000,KW,7, , ,,$/kw-mo,PJM,Point A,PJM,Point B,,,ep
+C76,The Electric Company,The Power Company,456534333,N,FERC Electric Tariff Original Volume No. 10,132,12/15/2001,1/1/2002,12/31/2004,12/31/2004,None,F,LT,M,FP,MB,CAPACITY,70,MW,3750, , ,70MW for each and every hour over the term of the agreement (7x24 schedule).,$/MW,,,,,,,ep
+C78,The Electric Company,"The Electric Marketing Co., LLC",23456789,Y,FERC Electric Tariff Original Volume No. 2,Service Agreement 1,1/2/1992,1/2/1992,1/1/2012,,Renewable annually by mutual agreement after termination date.,UP,LT,Y,FP,CB,ENERGY,0,MWH,35, , ,,$/MWH,,,PJM,Bus 4321,20020101,20030101,EP
+C78,The Electric Company,"The Electric Marketing Co., LLC",23456789,Y,FERC Electric Tariff Original Volume No. 2,Service Agreement 1,1/2/1992,1/2/1992,1/1/2012,,Renewable annually by mutual agreement after termination date.,UP,LT,Y,FP,CB,ENERGY,0,MWH,37, , ,,$/MWH,,,PJM,Bus 4321,20030101,20040101,EP
+C78,The Electric Company,"The Electric Marketing Co., LLC",23456789,Y,FERC Electric Tariff Original Volume No. 2,Service Agreement 1,1/2/1992,1/2/1992,1/1/2012,,Renewable annually by mutual agreement after termination date.,UP,LT,Y,FP,CB,ENERGY,0,MWH,39, , ,,$/MWH,,,PJM,Bus 4321,20040101,20050101,EP
+C78,The Electric Company,"The Electric Marketing Co., LLC",23456789,Y,FERC Electric Tariff Original Volume No. 2,Service Agreement 1,1/2/1992,1/2/1992,1/1/2012,,Renewable annually by mutual agreement after termination date.,UP,LT,Y,FP,CB,ENERGY,0,MWH,41, , ,,$/MWH,,,PJM,Bus 4321,20050101,20060101,EP
+C78,The Electric Company,"The Electric Marketing Co., LLC",23456789,Y,FERC Electric Tariff Original Volume No. 2,Service Agreement 1,1/2/1992,1/2/1992,1/1/2012,,Renewable annually by mutual agreement after termination date.,UP,LT,Y,FP,CB,ENERGY,0,MWH,43, , ,,$/MWH,,,PJM,Bus 4321,20060101,20070101,EP
+C78,The Electric Company,"The Electric Marketing Co., LLC",23456789,Y,FERC Electric Tariff Original Volume No. 2,Service Agreement 1,1/2/1992,1/2/1992,1/1/2012,,Renewable annually by mutual agreement after termination date.,UP,LT,Y,FP,CB,ENERGY,0,MWH,45, , ,,$/MWH,,,PJM,Bus 4321,20070101,20080101,EP
+C78,The Electric Company,"The Electric Marketing Co., LLC",23456789,Y,FERC Electric Tariff Original Volume No. 2,Service Agreement 1,1/2/1992,1/2/1992,1/1/2012,,Renewable annually by mutual agreement after termination date.,UP,LT,Y,FP,CB,ENERGY,0,MWH,47, , ,,$/MWH,,,PJM,Bus 4321,20080101,20090101,EP
+C78,The Electric Company,"The Electric Marketing Co., LLC",23456789,Y,FERC Electric Tariff Original Volume No. 2,Service Agreement 1,1/2/1992,1/2/1992,1/1/2012,,Renewable annually by mutual agreement after termination date.,UP,LT,Y,FP,CB,ENERGY,0,MWH,49, , ,,$/MWH,,,PJM,Bus 4321,20090101,20100101,EP
+C78,The Electric Company,"The Electric Marketing Co., LLC",23456789,Y,FERC Electric Tariff Original Volume No. 2,Service Agreement 1,1/2/1992,1/2/1992,1/1/2012,,Renewable annually by mutual agreement after termination date.,UP,LT,Y,FP,CB,ENERGY,0,MWH,51, , ,,$/MWH,,,PJM,Bus 4321,20100101,20110101,EP
+C78,The Electric Company,"The Electric Marketing Co., LLC",23456789,Y,FERC Electric Tariff Original Volume No. 2,Service Agreement 1,1/2/1992,1/2/1992,1/1/2012,,Renewable annually by mutual agreement after termination date.,UP,LT,Y,FP,CB,ENERGY,0,MWH,53, , ,,$/MWH,,,PJM,Bus 4321,20110101,20120101,EP
Propchange: commons/proper/csv/trunk/src/test/resources/ferc.gov/contract.txt
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: commons/proper/csv/trunk/src/test/resources/ferc.gov/contract.txt
------------------------------------------------------------------------------
svn:keywords = Id
Added: commons/proper/csv/trunk/src/test/resources/ferc.gov/readme.txt
URL: http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/test/resources/ferc.gov/readme.txt?rev=1509068&view=auto
==============================================================================
--- commons/proper/csv/trunk/src/test/resources/ferc.gov/readme.txt (added)
+++ commons/proper/csv/trunk/src/test/resources/ferc.gov/readme.txt Thu Aug 1 02:03:33 2013
@@ -0,0 +1 @@
+Real world examples from http://www.ferc.gov/docs-filing/eqr/soft-tools/sample-csv.asp
Propchange: commons/proper/csv/trunk/src/test/resources/ferc.gov/readme.txt
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: commons/proper/csv/trunk/src/test/resources/ferc.gov/readme.txt
------------------------------------------------------------------------------
svn:keywords = Id
Added: commons/proper/csv/trunk/src/test/resources/ferc.gov/transaction.txt
URL: http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/test/resources/ferc.gov/transaction.txt?rev=1509068&view=auto
==============================================================================
--- commons/proper/csv/trunk/src/test/resources/ferc.gov/transaction.txt (added)
+++ commons/proper/csv/trunk/src/test/resources/ferc.gov/transaction.txt Thu Aug 1 02:03:33 2013
@@ -0,0 +1,25 @@
+transaction_unique_identifier,seller_company_name,customer_company_name,customer_duns_number,tariff_reference,contract_service_agreement,trans_id,transaction_begin_date,transaction_end_date,time_zone,point_of_delivery_control_area,specific location,class_name,term_name,increment_name,increment_peaking_name,product_name,transaction_quantity,price,units,total_transmission_charge,transaction_charge
+T1,The Electric Company,"The Electric Marketing Co., LLC",23456789,FERC Electric Tariff Original Volume No. 2,Service Agreement 1,8700,200401010000,200403312359,ES,PJM,BUS 4321,UP,LT,Y,FP,ENERGY,22574,39,$/MWH,0,880386
+T2,The Electric Company,The Power Company,45653333,FERC Electric Tariff Original Volume No. 10,2,8701,200401010000,200402010000,CS,DPL,Green Sub Busbar,F,ST,M,FP,ENERGY,16800,32,$/MWH,0,537600
+T3,The Electric Company,The Power Company,45653333,FERC Electric Tariff Original Volume No. 10,2,8702,200402010000,200403010000,CS,DPL,Green Sub Busbar,F,ST,M,FP,ENERGY,16800,32,$/MWH,0,537600
+T4,The Electric Company,The Power Company,45653333,FERC Electric Tariff Original Volume No. 10,2,8703,200403010000,200404010000,CS,DPL,Green Sub Busbar,F,ST,M,FP,ENERGY,16800,32,$/MWH,0,537600
+T5,The Electric Company,The Power Company,45653333,FERC Electric Tariff Original Volume No. 10,2,8704,200401111600,200401121559,CS,AEP,Tile Busbar,F,ST,D,FP,ENERGY,1200,50,$/MWH,0,60000
+T6,The Electric Company,The Power Company,45653333,FERC Electric Tariff Original Volume No. 10,2,8801,200402011300,20040215061900,ES,HUB,Entergy (into),NF,ST,H,FP,ENERGY,1875,13.75,$/MWH,6675,32456.25
+T7,The Electric Company,The Power Company,45653333,FERC Electric Tariff Original Volume No. 10,2,8802,20040202110000,200402021800,ES,HUB,PJM-W,NF,ST,H,FP,BOOKED OUT POWER,350,32,$/MWH,0,11200
+T8,The Electric Company,The Power Company,45653333,FERC Electric Tariff Original Volume No. 10,2,8803,20040203060500,20040210112200,ES,HUB,PJM-W,NF,ST,H,FP,ENERGY,1875,44,$/MWH,0,82500
+T9,The Electric Company,The Power Company,45653333,FERC Electric Tariff Original Volume No. 10,2,8804,20040211062300,20040219081200,PP,HUB,Four Corners,NF,ST,H,FP,ENERGY,1875,48,$/MWH,0,90000
+T10,The Electric Company,The Power Company,45653333,FERC Electric Tariff Original Volume No. 10,132,7125,20040109081100,20040309082300,CS,HUB,AEP (into),F,ST,H,OP,ENERGY,150,22,$/MWH,4264,7564
+T10,The Electric Company,The Power Company,45653333,FERC Electric Tariff Original Volume No. 10,132,7125,20040201010000,20040225080800,CS,HUB,AEP (into),F,ST,H,OP,ENERGY,150,28,$/MWH,0,4200
+T10,The Electric Company,The Power Company,45653333,FERC Electric Tariff Original Volume No. 10,132,7125,20040108111100,20040301121200,CS,HUB,AEP (into),F,ST,H,OP,ENERGY,150,44,$/MWH,0,6600
+T10,The Electric Company,The Power Company,45653333,FERC Electric Tariff Original Volume No. 10,132,7125,20040322112200,20040325120000,CS,HUB,AEP (into),F,ST,H,OP,ENERGY,150,44,$/MWH,0,6600
+T10,The Electric Company,The Power Company,45653333,FERC Electric Tariff Original Volume No. 10,132,7125,20040323191900,20040328191700,CS,HUB,AEP (into),F,ST,H,OP,ENERGY,150,58,$/MWH,0,8700
+T10,The Electric Company,The Power Company,45653333,FERC Electric Tariff Original Volume No. 10,132,7125,20040111010000,20040122022200,CS,HUB,AEP (into),F,ST,H,OP,CAPACITY,150,20,$/MW-DAY,0,3000
+T11,The Electric Company,Utility A,38495837,FERC Electric Tariff Original Volume No. 10,15,8711,200403150800,200403150859,ES,ISNE,NEPOOL Mass HUB,F,ST,H,P,Energy,100,50,$/MWH,0,5000
+T11,The Electric Company,Utility A,38495837,FERC Electric Tariff Original Volume No. 10,15,8711,200403150800,200403150859,ES,ISNE,NEPOOL Mass HUB,F,ST,H,P,Energy,-10,60,$/MWH,0,-600
+T12,The Electric Company,Utility A,38495837,FERC Electric Tariff Original Volume No. 10,15,8711,200403150900,200403150959,ES,ISNE,NEPOOL Mass HUB,F,ST,H,P,Energy,100,55,$/MWH,0,5500
+T12,The Electric Company,Utility A,38495837,FERC Electric Tariff Original Volume No. 10,15,8711,200403150900,200403150959,ES,ISNE,NEPOOL Mass HUB,F,ST,H,P,Energy,-5,59,$/MWH,0,-295
+T13,The Electric Company,Utility A,38495837,FERC Electric Tariff Original Volume No. 10,15,8711,200403151000,200403151059,ES,ISNE,NEPOOL Mass HUB,F,ST,H,P,Energy,100,62,$/MWH,0,6200
+T13,The Electric Company,Utility A,38495837,FERC Electric Tariff Original Volume No. 10,15,8711,200403151000,200403151059,ES,ISNE,NEPOOL Mass HUB,F,ST,H,P,Energy,-10,60,$/MWH,0,-600
+T14,The Electric Company,Utility A,38495837,FERC Electric Tariff Original Volume No. 10,15,8711,200403151100,200403151159,ES,ISNE,NEPOOL Mass HUB,F,ST,H,P,Energy,100,62,$/MWH,0,6200
+T14,The Electric Company,Utility A,38495837,FERC Electric Tariff Original Volume No. 10,15,8711,200403151100,200403151159,ES,ISNE,NEPOOL Mass HUB,F,ST,H,P,Energy,-10,59,$/MWH,0,-590
+T15,The Electric Company,Utility B,493758794,FERC Electric Tariff Original Volume No. 10,7,8712,200402140200,200402140259,EP,NYIS,Zone A,F,ST,H,FP,Booked out power,60,30,$/MWH,0,1800
Propchange: commons/proper/csv/trunk/src/test/resources/ferc.gov/transaction.txt
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: commons/proper/csv/trunk/src/test/resources/ferc.gov/transaction.txt
------------------------------------------------------------------------------
svn:keywords = Id
Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src:
main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/ test/resources/ferc.gov/
Posted by Benedikt Ritter <br...@apache.org>.
Hi Gary,
2013/8/1 <gg...@apache.org>
> Author: ggregory
> Date: Thu Aug 1 02:03:33 2013
> New Revision: 1509068
>
> URL: http://svn.apache.org/r1509068
> Log:
> - Add some real world CSV files.
> - Add a record API to get column values using an Enum.
> - Throw a better exception when a resource is not found in a class loader
> for the parser.
> - Replace some tabs with spaces.
>
<snip>
>
> @@ -371,9 +400,9 @@ public class CSVParser implements Iterab
> }
>
> public boolean hasNext() {
> - if (CSVParser.this.isClosed()) {
> - return false;
> - }
> + if (CSVParser.this.isClosed()) {
> + return false;
> + }
> if (this.current == null) {
> this.current = this.getNextRecord();
> }
> @@ -382,9 +411,9 @@ public class CSVParser implements Iterab
> }
>
> public CSVRecord next() {
> - if (CSVParser.this.isClosed()) {
> - return null;
> - }
> + if (CSVParser.this.isClosed()) {
> + return null;
> + }
> CSVRecord next = this.current;
> this.current = null;
>
>
JavaDoc of the Iterator interface says that next() throws a
NoSuchElementExecption if there are no more elements [1]. I'm not sure if
this applies if the parser is closed. WDYT?
Benedikt
[1] http://docs.oracle.com/javase/6/docs/api/java/util/Iterator.html#next()
--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src:
main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/ test/resources/ferc.gov/
Posted by James Carman <ja...@carmanconsulting.com>.
Are you kidding me? We can't ascertain a file format from some
example file and create a similarly-formatted file in our test
resources which exhibits this format to make sure we handle it? It's
CSV! I can't imagine anyone can claim this is their IP. Do they have
a patent on using CSV in this fashion?
On Thu, Aug 1, 2013 at 10:08 AM, sebb <se...@gmail.com> wrote:
> On 1 August 2013 14:51, James Carman <ja...@carmanconsulting.com> wrote:
>> Why not just create files that look like these files? Do we have to
>> use the originals?
>
> If it's necessary to read the originals to create the look-alikes,
> that seems like cheating to me.
> I don't think that's something as a part of the ASF that Commons
> should even consider.
>
>> On Thu, Aug 1, 2013 at 9:22 AM, Gary Gregory <ga...@gmail.com> wrote:
>>> On Thu, Aug 1, 2013 at 8:56 AM, sebb <se...@gmail.com> wrote:
>>>
>>>> On 1 August 2013 13:48, Gary Gregory <ga...@gmail.com> wrote:
>>>> > On Thu, Aug 1, 2013 at 5:48 AM, Emmanuel Bourg <eb...@apache.org>
>>>> wrote:
>>>> >
>>>> >> Le 01/08/2013 04:03, ggregory@apache.org a écrit :
>>>> >>
>>>> >> > - Add some real world CSV files.
>>>> >>
>>>> >> Are we allowed to distribute these files?
>>>> >>
>>>> >
>>>> > I did not see any copyrights, or licenses. I did not text that states you
>>>> > cannot. I do see text about "Open Government Initiatives" here
>>>> > http://www.ferc.gov/open.asp but that does not talk specifically about
>>>> > these sample files (as far as I read at least, which is not that deeply.)
>>>>
>>>> Since there is some uncertainty, please ask on legal-discuss (and/or
>>>> via a LEGAL JIRA) first.
>>>>
>>>
>>> I created https://issues.apache.org/jira/browse/LEGAL-175
>>>
>>> Gary
>>>
>>>
>>>> In the meantime, I think the CSV files should be removed.
>>>>
>>>> Even if we are allowed to redistribute the files (note: we are not
>>>> just using them), I expect there will need to be at least a mention in
>>>> the LICENSE file.
>>>>
>>>> > Gary
>>>> >
>>>> >
>>>> >>
>>>> >> Emmanuel Bourg
>>>> >>
>>>> >>
>>>> >> ---------------------------------------------------------------------
>>>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> >> For additional commands, e-mail: dev-help@commons.apache.org
>>>> >>
>>>> >>
>>>> >
>>>> >
>>>> > --
>>>> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> > Java Persistence with Hibernate, Second Edition<
>>>> http://www.manning.com/bauer3/>
>>>> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>> > Spring Batch in Action <http://www.manning.com/templier/>
>>>> > Blog: http://garygregory.wordpress.com
>>>> > Home: http://garygregory.com/
>>>> > Tweet! http://twitter.com/GaryGregory
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>>
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src:
main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/ test/resources/ferc.gov/
Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Aug 1, 2013 at 10:52 AM, Emmanuel Bourg <eb...@apache.org> wrote:
> Le 01/08/2013 16:48, Gary Gregory a écrit :
>
> > I agree with Sebb. In addition, the whole point is to use 'real world'
> > files. If we are not allowed this particular file set, then that's too
> bad.
>
> Alternatively, if the URL is stable the file could be downloaded during
> the tests.
>
I thought about that, especially since the parser has a parseURL method now
;) But... I did not want to create an external dependency that might not be
stable over the long term.
Gary
>
> Emmanuel Bourg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/
test/java/org/apache/commons/csv/ test/resources/ferc.gov/
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 01/08/2013 16:48, Gary Gregory a écrit :
> I agree with Sebb. In addition, the whole point is to use 'real world'
> files. If we are not allowed this particular file set, then that's too bad.
Alternatively, if the URL is stable the file could be downloaded during
the tests.
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src:
main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/ test/resources/ferc.gov/
Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Aug 1, 2013 at 10:08 AM, sebb <se...@gmail.com> wrote:
> On 1 August 2013 14:51, James Carman <ja...@carmanconsulting.com> wrote:
> > Why not just create files that look like these files? Do we have to
> > use the originals?
>
> If it's necessary to read the originals to create the look-alikes,
> that seems like cheating to me.
> I don't think that's something as a part of the ASF that Commons
> should even consider.
>
I agree with Sebb. In addition, the whole point is to use 'real world'
files. If we are not allowed this particular file set, then that's too bad.
Gary
>
> > On Thu, Aug 1, 2013 at 9:22 AM, Gary Gregory <ga...@gmail.com>
> wrote:
> >> On Thu, Aug 1, 2013 at 8:56 AM, sebb <se...@gmail.com> wrote:
> >>
> >>> On 1 August 2013 13:48, Gary Gregory <ga...@gmail.com> wrote:
> >>> > On Thu, Aug 1, 2013 at 5:48 AM, Emmanuel Bourg <eb...@apache.org>
> >>> wrote:
> >>> >
> >>> >> Le 01/08/2013 04:03, ggregory@apache.org a écrit :
> >>> >>
> >>> >> > - Add some real world CSV files.
> >>> >>
> >>> >> Are we allowed to distribute these files?
> >>> >>
> >>> >
> >>> > I did not see any copyrights, or licenses. I did not text that
> states you
> >>> > cannot. I do see text about "Open Government Initiatives" here
> >>> > http://www.ferc.gov/open.asp but that does not talk specifically
> about
> >>> > these sample files (as far as I read at least, which is not that
> deeply.)
> >>>
> >>> Since there is some uncertainty, please ask on legal-discuss (and/or
> >>> via a LEGAL JIRA) first.
> >>>
> >>
> >> I created https://issues.apache.org/jira/browse/LEGAL-175
> >>
> >> Gary
> >>
> >>
> >>> In the meantime, I think the CSV files should be removed.
> >>>
> >>> Even if we are allowed to redistribute the files (note: we are not
> >>> just using them), I expect there will need to be at least a mention in
> >>> the LICENSE file.
> >>>
> >>> > Gary
> >>> >
> >>> >
> >>> >>
> >>> >> Emmanuel Bourg
> >>> >>
> >>> >>
> >>> >>
> ---------------------------------------------------------------------
> >>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >>> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>> >>
> >>> >>
> >>> >
> >>> >
> >>> > --
> >>> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> >>> > Java Persistence with Hibernate, Second Edition<
> >>> http://www.manning.com/bauer3/>
> >>> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> >>> > Spring Batch in Action <http://www.manning.com/templier/>
> >>> > Blog: http://garygregory.wordpress.com
> >>> > Home: http://garygregory.com/
> >>> > Tweet! http://twitter.com/GaryGregory
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >>> For additional commands, e-mail: dev-help@commons.apache.org
> >>>
> >>>
> >>
> >>
> >> --
> >> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> >> Java Persistence with Hibernate, Second Edition<
> http://www.manning.com/bauer3/>
> >> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> >> Spring Batch in Action <http://www.manning.com/templier/>
> >> Blog: http://garygregory.wordpress.com
> >> Home: http://garygregory.com/
> >> Tweet! http://twitter.com/GaryGregory
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src:
main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/ test/resources/ferc.gov/
Posted by sebb <se...@gmail.com>.
On 1 August 2013 14:51, James Carman <ja...@carmanconsulting.com> wrote:
> Why not just create files that look like these files? Do we have to
> use the originals?
If it's necessary to read the originals to create the look-alikes,
that seems like cheating to me.
I don't think that's something as a part of the ASF that Commons
should even consider.
> On Thu, Aug 1, 2013 at 9:22 AM, Gary Gregory <ga...@gmail.com> wrote:
>> On Thu, Aug 1, 2013 at 8:56 AM, sebb <se...@gmail.com> wrote:
>>
>>> On 1 August 2013 13:48, Gary Gregory <ga...@gmail.com> wrote:
>>> > On Thu, Aug 1, 2013 at 5:48 AM, Emmanuel Bourg <eb...@apache.org>
>>> wrote:
>>> >
>>> >> Le 01/08/2013 04:03, ggregory@apache.org a écrit :
>>> >>
>>> >> > - Add some real world CSV files.
>>> >>
>>> >> Are we allowed to distribute these files?
>>> >>
>>> >
>>> > I did not see any copyrights, or licenses. I did not text that states you
>>> > cannot. I do see text about "Open Government Initiatives" here
>>> > http://www.ferc.gov/open.asp but that does not talk specifically about
>>> > these sample files (as far as I read at least, which is not that deeply.)
>>>
>>> Since there is some uncertainty, please ask on legal-discuss (and/or
>>> via a LEGAL JIRA) first.
>>>
>>
>> I created https://issues.apache.org/jira/browse/LEGAL-175
>>
>> Gary
>>
>>
>>> In the meantime, I think the CSV files should be removed.
>>>
>>> Even if we are allowed to redistribute the files (note: we are not
>>> just using them), I expect there will need to be at least a mention in
>>> the LICENSE file.
>>>
>>> > Gary
>>> >
>>> >
>>> >>
>>> >> Emmanuel Bourg
>>> >>
>>> >>
>>> >> ---------------------------------------------------------------------
>>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> >> For additional commands, e-mail: dev-help@commons.apache.org
>>> >>
>>> >>
>>> >
>>> >
>>> > --
>>> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> > Java Persistence with Hibernate, Second Edition<
>>> http://www.manning.com/bauer3/>
>>> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> > Spring Batch in Action <http://www.manning.com/templier/>
>>> > Blog: http://garygregory.wordpress.com
>>> > Home: http://garygregory.com/
>>> > Tweet! http://twitter.com/GaryGregory
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src:
main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/ test/resources/ferc.gov/
Posted by James Carman <ja...@carmanconsulting.com>.
Why not just create files that look like these files? Do we have to
use the originals?
On Thu, Aug 1, 2013 at 9:22 AM, Gary Gregory <ga...@gmail.com> wrote:
> On Thu, Aug 1, 2013 at 8:56 AM, sebb <se...@gmail.com> wrote:
>
>> On 1 August 2013 13:48, Gary Gregory <ga...@gmail.com> wrote:
>> > On Thu, Aug 1, 2013 at 5:48 AM, Emmanuel Bourg <eb...@apache.org>
>> wrote:
>> >
>> >> Le 01/08/2013 04:03, ggregory@apache.org a écrit :
>> >>
>> >> > - Add some real world CSV files.
>> >>
>> >> Are we allowed to distribute these files?
>> >>
>> >
>> > I did not see any copyrights, or licenses. I did not text that states you
>> > cannot. I do see text about "Open Government Initiatives" here
>> > http://www.ferc.gov/open.asp but that does not talk specifically about
>> > these sample files (as far as I read at least, which is not that deeply.)
>>
>> Since there is some uncertainty, please ask on legal-discuss (and/or
>> via a LEGAL JIRA) first.
>>
>
> I created https://issues.apache.org/jira/browse/LEGAL-175
>
> Gary
>
>
>> In the meantime, I think the CSV files should be removed.
>>
>> Even if we are allowed to redistribute the files (note: we are not
>> just using them), I expect there will need to be at least a mention in
>> the LICENSE file.
>>
>> > Gary
>> >
>> >
>> >>
>> >> Emmanuel Bourg
>> >>
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >> For additional commands, e-mail: dev-help@commons.apache.org
>> >>
>> >>
>> >
>> >
>> > --
>> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> > Java Persistence with Hibernate, Second Edition<
>> http://www.manning.com/bauer3/>
>> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> > Spring Batch in Action <http://www.manning.com/templier/>
>> > Blog: http://garygregory.wordpress.com
>> > Home: http://garygregory.com/
>> > Tweet! http://twitter.com/GaryGregory
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src:
main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/ test/resources/ferc.gov/
Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Aug 1, 2013 at 8:56 AM, sebb <se...@gmail.com> wrote:
> On 1 August 2013 13:48, Gary Gregory <ga...@gmail.com> wrote:
> > On Thu, Aug 1, 2013 at 5:48 AM, Emmanuel Bourg <eb...@apache.org>
> wrote:
> >
> >> Le 01/08/2013 04:03, ggregory@apache.org a écrit :
> >>
> >> > - Add some real world CSV files.
> >>
> >> Are we allowed to distribute these files?
> >>
> >
> > I did not see any copyrights, or licenses. I did not text that states you
> > cannot. I do see text about "Open Government Initiatives" here
> > http://www.ferc.gov/open.asp but that does not talk specifically about
> > these sample files (as far as I read at least, which is not that deeply.)
>
> Since there is some uncertainty, please ask on legal-discuss (and/or
> via a LEGAL JIRA) first.
>
I created https://issues.apache.org/jira/browse/LEGAL-175
Gary
> In the meantime, I think the CSV files should be removed.
>
> Even if we are allowed to redistribute the files (note: we are not
> just using them), I expect there will need to be at least a mention in
> the LICENSE file.
>
> > Gary
> >
> >
> >>
> >> Emmanuel Bourg
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > Java Persistence with Hibernate, Second Edition<
> http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src:
main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/ test/resources/ferc.gov/
Posted by sebb <se...@gmail.com>.
On 1 August 2013 13:48, Gary Gregory <ga...@gmail.com> wrote:
> On Thu, Aug 1, 2013 at 5:48 AM, Emmanuel Bourg <eb...@apache.org> wrote:
>
>> Le 01/08/2013 04:03, ggregory@apache.org a écrit :
>>
>> > - Add some real world CSV files.
>>
>> Are we allowed to distribute these files?
>>
>
> I did not see any copyrights, or licenses. I did not text that states you
> cannot. I do see text about "Open Government Initiatives" here
> http://www.ferc.gov/open.asp but that does not talk specifically about
> these sample files (as far as I read at least, which is not that deeply.)
Since there is some uncertainty, please ask on legal-discuss (and/or
via a LEGAL JIRA) first.
In the meantime, I think the CSV files should be removed.
Even if we are allowed to redistribute the files (note: we are not
just using them), I expect there will need to be at least a mention in
the LICENSE file.
> Gary
>
>
>>
>> Emmanuel Bourg
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src:
main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/ test/resources/ferc.gov/
Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Aug 1, 2013 at 5:48 AM, Emmanuel Bourg <eb...@apache.org> wrote:
> Le 01/08/2013 04:03, ggregory@apache.org a écrit :
>
> > - Add some real world CSV files.
>
> Are we allowed to distribute these files?
>
I did not see any copyrights, or licenses. I did not text that states you
cannot. I do see text about "Open Government Initiatives" here
http://www.ferc.gov/open.asp but that does not talk specifically about
these sample files (as far as I read at least, which is not that deeply.)
Gary
>
> Emmanuel Bourg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/
test/java/org/apache/commons/csv/ test/resources/ferc.gov/
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 01/08/2013 04:03, ggregory@apache.org a écrit :
> - Add some real world CSV files.
Are we allowed to distribute these files?
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org