[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5722: Introduce IndexContainer in MutableSegmentImpl to reduce map lookups

[GitBox <gi...@apache.org>]

kishoreg commented on a change in pull request #5722:
URL: https://github.com/apache/incubator-pinot/pull/5722#discussion_r458337163



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -108,19 +110,8 @@
   private final int _partitionId;
   private final boolean _nullHandlingEnabled;
 
-  // TODO: Keep one map to store all these info
-  private final Map<String, NumValuesInfo> _numValuesInfoMap = new HashMap<>();
-  private final Map<String, BaseMutableDictionary> _dictionaryMap = new HashMap<>();
-  private final Map<String, MutableForwardIndex> _forwardIndexMap = new HashMap<>();
-  private final Map<String, InvertedIndexReader> _invertedIndexMap = new HashMap<>();
-  private final Map<String, InvertedIndexReader> _rangeIndexMap = new HashMap<>();
-  private final Map<String, InvertedIndexReader> _textIndexMap = new HashMap<>();
-  private final Map<String, BloomFilterReader> _bloomFilterMap = new HashMap<>();
-  // Only store min/max for non-dictionary fields
-  private final Map<String, Comparable> _minValueMap = new HashMap<>();
-  private final Map<String, Comparable> _maxValueMap = new HashMap<>();
-
-  private final Map<String, RealtimeNullValueVectorReaderWriter> _nullValueVectorMap = new HashMap<>();
+  private final Map<String, IndexContainer> _indexContainerMap = new HashMap<>();

Review comment:
       should this be IndexKey instead of String?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org