You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "codeconsole (via GitHub)" <gi...@apache.org> on 2026/10/04 14:49:18 UTC

[PR] Add grails-compile-static Forge feature [grails-core]

codeconsole opened a new pull request, #16512:
URL: https://github.com/apache/grails-core/pull/16512

   ## Description
   
   Split out of #16499 during review, where both reviewers were fine with this part.
   
   Selecting the new `grails-compile-static` Forge feature generates the `compileStatic` block of the `grails` build configuration:
   
   ```groovy
   grails {
       compileStatic {
           all = true
           gsp = true   // only when the application uses GSP
       }
   }
   ```
   
   `all` covers controllers, services and tag libraries but deliberately not GSP, so the feature writes `gsp = true` too when the application has GSP. A REST API application gets `all = true` alone.
   
   The block is written by `buildGradle.rocker.raw`, the same way the existing `assets { }` block is. The feature is listed under Configuration and documented in What's New and in `grailsCompileStatic.adoc`, after the `all`/`gsp` example it generates.
   
   ### Testing
   
   - `GrailsCompileStaticSpec` checks the block for a web application, `all` without `gsp` for a REST API application, and no block without the feature.
   - `CreateAppSpec` generates an application with the feature and runs `compileGroovyPages`, so a generated application, its starter page included, has to compile statically.
   - `./gradlew :grails-forge-core:codeStyle` passes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add grails-compile-static Forge feature [grails-core]

Posted by "codeconsole (via GitHub)" <gi...@apache.org>.
codeconsole closed pull request #16512: Add grails-compile-static Forge feature
URL: https://github.com/apache/grails-core/pull/16512


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add grails-compile-static Forge feature [grails-core]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #16512:
URL: https://github.com/apache/grails-core/pull/16512#issuecomment-5981773273

   ## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16512?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 59.5213%. Comparing base ([`175e4c2`](https://app.codecov.io/gh/apache/grails-core/commit/175e4c2812eeb652b732c98025e27b0eb37c217f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7dedb2b`](https://app.codecov.io/gh/apache/grails-core/commit/7dedb2b7bd12809f725b717f2b7a9379e41884c3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 20 commits behind head on 8.0.x.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/grails-core/pull/16512/graphs/tree.svg?width=650&height=150&src=pr&token=qJrryhpk7u&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/grails-core/pull/16512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##                8.0.x     #16512        +/-   ##
   ==================================================
   - Coverage     59.5234%   59.5213%   -0.0020%     
     Complexity      25014      25014                
   ==================================================
     Files            2175       2175                
     Lines          108633     108635         +2     
     Branches        19822      19822                
   ==================================================
   - Hits            64662      64661         -1     
   - Misses          35016      35019         +3     
     Partials         8955       8955                
   ```
   [see 5 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16512/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org