You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2026/05/03 02:38:13 UTC

[PR] GH-49744: [Integration][Format] Remove unneeded skips for Rust and nanoarrow integration tests [arrow]

paleolimbot opened a new pull request, #49910:
URL: https://github.com/apache/arrow/pull/49910

   ### Rationale for this change
   
   The current skip list in the Archery datagen (where the skip list is kept) is out of date.
   
   ### What changes are included in this PR?
   
   Skips were removed.
   
   ### Are these changes tested?
   
   Yes, the integration test CI run should ensure these skips can in fact be removed.
   
   ### Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49744: [Integration][Format] Remove unneeded skips for Rust and nanoarrow integration tests [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #49910:
URL: https://github.com/apache/arrow/pull/49910#issuecomment-4466038896

   After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 72bb3e303bf5bdcbbf07ec1a28c6db97452ed4fb.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/76300505104) has more details. It also includes information about 22 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49744: [Integration][Format] Remove unneeded skips for Rust and nanoarrow integration tests [arrow]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #49910:
URL: https://github.com/apache/arrow/pull/49910#discussion_r3248817341


##########
dev/archery/archery/integration/datagen.py:
##########
@@ -1936,17 +1936,13 @@ def get_generated_json_files(tempdir=None):
         generate_decimal32_case()
         .skip_tester('Java')
         .skip_tester('JS')
-        .skip_tester('nanoarrow')
         .skip_tester('Ruby')
-        .skip_tester('Rust')
         .skip_tester('Go'),
 
         generate_decimal64_case()
         .skip_tester('Java')
         .skip_tester('JS')
-        .skip_tester('nanoarrow')
         .skip_tester('Ruby')
-        .skip_tester('Rust')

Review Comment:
   this is great



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49744: [Integration][Format] Remove unneeded skips for Rust and nanoarrow integration tests [arrow]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #49910:
URL: https://github.com/apache/arrow/pull/49910#issuecomment-4460575771

   🥳 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49744: [Integration][Format] Remove unneeded skips for Rust and nanoarrow integration tests [arrow]

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #49910:
URL: https://github.com/apache/arrow/pull/49910


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49744: [Integration][Format] Remove unneeded skips for Rust and nanoarrow integration tests [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49910:
URL: https://github.com/apache/arrow/pull/49910#issuecomment-4365232487

   :warning: GitHub issue #49744 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49744: [Integration][Format] Remove unneeded skips for Rust and nanoarrow integration tests [arrow]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #49910:
URL: https://github.com/apache/arrow/pull/49910#discussion_r3261693085


##########
dev/archery/archery/integration/datagen.py:
##########
@@ -2003,25 +1999,24 @@ def get_generated_json_files(tempdir=None):
         .skip_tester('JS')
         # TODO(https://github.com/apache/arrow-nanoarrow/issues/618)
         .skip_tester('nanoarrow')
-        .skip_tester('Ruby')
-        .skip_tester('Rust'),
+        .skip_tester('Ruby'),
 
         generate_binary_view_case()
         .skip_tester('JS')
         # TODO(https://github.com/apache/arrow-nanoarrow/issues/618)
         .skip_tester('nanoarrow')
-        .skip_tester('Ruby')
-        .skip_tester('Rust'),
+        .skip_tester('Ruby'),

Review Comment:
   It seems this test is now failing on our CI (when testing with .NET) 🤔  
   - https://github.com/apache/arrow-rs/issues/9989



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org