You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/09/09 12:10:56 UTC
[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #205: [YUNIKORN-326]Add rest API to retrieve cluster nodes resource utilization
TravisBuddy commented on pull request #205:
URL: https://github.com/apache/incubator-yunikorn-core/pull/205#issuecomment-689520647
## Travis tests have failed
Hey @HuangTing-Yao,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
### 1st Build
<a href="https://travis-ci.org/apache/incubator-yunikorn-core/jobs/725555644">View build log</a>
<details>
<summary>
<strong>
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.22.2
</strong>
</summary>
```
golangci/golangci-lint info checking GitHub for tag 'v1.22.2'
golangci/golangci-lint info found version: 1.22.2 for v1.22.2/linux/amd64
golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint
```
</details>
<details>
<summary>
<strong>
make lint
</strong>
</summary>
```
running golangci-lint
pkg/webservice/handlers.go:158:13: should omit 2nd value from range; this loop is equivalent to `for name := range ...` (golint)
for name, _ := range partition.GetTotalPartitionResource().Resources {
^
pkg/webservice/dao/node_util.go:22: File is not `gofmt`-ed with `-s` (gofmt)
ResourceType string `json:"type"`
NodesUtil []*NodeUtilDAOInfo `json:"utilization"`
pkg/webservice/handlers.go:28: File is not `gofmt`-ed with `-s` (gofmt)
"math"
pkg/webservice/handlers.go:159: File is not `goimports`-ed with -local github.com/apache/incubator-yunikorn (goimports)
if name == "memory" ||name == "vcore"{
Makefile:45: recipe for target 'lint' failed
make: *** [lint] Error 1
```
</details>
###### TravisBuddy Request Identifier: 7aecf560-f295-11ea-82b8-f1691ab9f797
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org