You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2015/10/28 12:04:27 UTC

[jira] [Created] (OAK-3563) Improve DefaultSyncContext

angela created OAK-3563:
---------------------------

             Summary: Improve DefaultSyncContext
                 Key: OAK-3563
                 URL: https://issues.apache.org/jira/browse/OAK-3563
             Project: Jackrabbit Oak
          Issue Type: Bug
          Components: auth-external
            Reporter: angela
            Assignee: Tobias Bocanegra
         Attachments: OAK-3523_4.patch

the group and group-member sync code in the {{DefaultSyncContext}} twice catches {{ClassCastException}} and swallows exception situations, where a user is found, when actually a {{Group}} was expected.

i would suggest to 
- explicitly test the assumption wrt {{ExternalIdentity}} being a group (instead of waiting for the exception)
- make use of {{UserManager.getAuthorizable(String, Class) to explicitly retrieve a Group with a given ID, when this is actually expected. This method will throws an {{AuthorizableTypeException}} if there exists a {{User}} with that ID as thus properly raise the unexpected behavior instead of swallowing with a log-warning.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)