You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by "Alex Parvulescu (JIRA)" <ji...@apache.org> on 2011/09/20 16:16:08 UTC

[jira] [Commented] (JCR-3077) WeightedHighlighter does not encode XML markup characters

    [ https://issues.apache.org/jira/browse/JCR-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108732#comment-13108732 ] 

Alex Parvulescu commented on JCR-3077:
--------------------------------------

a tiny feedback on your patch ;)

> - adds a test case
I think it would be better if the test was in the "ExcerptTest" class.

> - puts the convenience method "escape" into the base class (and uses it throughout)
I like the "escape" refactoring. 
Why is it not static? Text.encodeIllegalXMLCharacters is static, what is the gain of adding a non-static method to call a static one?

> - removes "static" from two methods on WeightedHighlighter
What is the benefit of making methods non static?


> WeightedHighlighter does not encode XML markup characters
> ---------------------------------------------------------
>
>                 Key: JCR-3077
>                 URL: https://issues.apache.org/jira/browse/JCR-3077
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>         Attachments: JCR-3077.patch, JCR-3077.patch
>
>
> See JCR-2611; the same problem applies to WeightedHighlighter.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira