[jira] [Commented] (FLINK-7150) Code improvements to the ElasticSearch connector

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082059#comment-16082059 ] 

ASF GitHub Bot commented on FLINK-7150:
---------------------------------------

GitHub user StephanEwen opened a pull request:

    https://github.com/apache/flink/pull/4298

    [FLINK-7150] [elasticsearch connector] Various code cleanups in the ElasticSearch connector

     - Removes `Serializable` from the `RequestIndexer`, because they are neither required to be
       serializable (they are created in open()) nor is the main implementation
       (`BulkProcessorIndexer`) actually serializable.
    
     - Makes `BulkFlushBackoffPolicy` a static inner class, which avoids adding outer class during
       serialization and clears various warnings about raw reference to outer class
    
     - Fixes various raw generic type warning


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StephanEwen/incubator-flink elastic_cleanups

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4298.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4298
    
----
commit b374fff2f9b01448f108ef402d54b9b03b302bfd
Author: Stephan Ewen <se...@apache.org>
Date:   2017-07-11T11:01:25Z

    [FLINK-7150] [elasticsearch connector] Various code cleanups in the ElasticSearch connector
    
     - Removes Serializable from the RequestIndexer, because they are neither required to be
       serializable (they are created in open()) nor is the main implementation
       (BulkProcessorIndexer) actually serializable.
    
     - Makes BulkFlushBackoffPolicy a static inner class, which avoids adding outer class during
       serialization and clears various warnings about raw reference to outer class
    
     - Fixes various raw generic type warning

----


> Code improvements to the ElasticSearch connector
> ------------------------------------------------
>
>                 Key: FLINK-7150
>                 URL: https://issues.apache.org/jira/browse/FLINK-7150
>             Project: Flink
>          Issue Type: Improvement
>          Components: ElasticSearch Connector
>    Affects Versions: 1.3.1
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>             Fix For: 1.4.0
>
>
> I suggest some improvements to the handling of generic types, inner classes, and serializability:
>   - Remove Serializable from the {{RequestIndexer}}, because they are neither required to be serializable (they are created in open()) nor is the main implementation ({{BulkProcessorIndexer}}) actually serializable.
>   - Make {{BulkFlushBackoffPolicy}} a static inner class, which avoids adding outer class during serialization and clears various warnings about raw reference to outer class
>   - Fixe various raw generic type warnings for the use of {{ActionRequest}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)