You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by "Yuting Gan (Jira)" <ji...@apache.org> on 2022/04/29 20:18:00 UTC

[jira] [Commented] (LUCENE-10538) TopN is not being used in getTopChildren()

    [ https://issues.apache.org/jira/browse/LUCENE-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530229#comment-17530229 ] 

Yuting Gan commented on LUCENE-10538:
-------------------------------------

Created a related issue [LUCENE-10550|https://issues.apache.org/jira/browse/LUCENE-10550] and would appreciate any feedback from the community. Thanks!

 

> TopN is not being used in getTopChildren()
> ------------------------------------------
>
>                 Key: LUCENE-10538
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10538
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Yuting Gan
>            Priority: Minor
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> When looking at the overridden implementation getTopChildren(int topN, String dim, String... path) in RangeFacetCounts, I found that the topN parameter is not being used in the code, and the unit tests did not test this function properly. I will create a PR to fix this, and will look into other overridden implementations and see if they have the same issue. Please let me know if there is any question. Thanks!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org